Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-31202: Preserve case of literal parts in Path.glob() on Windows. #16860

Merged
merged 1 commit into from Oct 21, 2019
Merged

bpo-31202: Preserve case of literal parts in Path.glob() on Windows. #16860

merged 1 commit into from Oct 21, 2019

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Oct 20, 2019 •
edited by bedevere-bot

@serhiy-storchaka serhiy-storchaka requested a review from zooba Oct 20, 2019
zooba
zooba approved these changes Oct 21, 2019
View changes
Copy link
Member

@zooba zooba left a comment

Thanks Serhiy!

@serhiy-storchaka serhiy-storchaka merged commit 10ecbad into python:master Oct 21, 2019
@serhiy-storchaka serhiy-storchaka deleted the pathlib-glob-case branch Oct 21, 2019
@miss-islington
Copy link
Contributor

miss-islington commented Oct 21, 2019

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Oct 21, 2019

Sorry @serhiy-storchaka, I had trouble checking out the 3.8 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 10ecbadb799ddf3393d1fc80119a3db14724d381 3.8

@bedevere-bot
Copy link

bedevere-bot commented Oct 21, 2019

GH-16874 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 21, 2019
@serhiy-storchaka @miss-islington
bpo-31202: Preserve case of literal parts in Path.glob() on Windows. (p…
94d52b5 
…ythonGH-16860)

(cherry picked from commit 10ecbad)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@miss-islington
Copy link
Contributor

miss-islington commented Oct 21, 2019

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Oct 21, 2019

I'm having trouble backporting to 3.8. Reason: 'Error 110 while writing to socket. Connection timed out.'. Please retry by removing and re-adding the needs backport to 3.8 label.

@miss-islington
Copy link
Contributor

miss-islington commented Oct 21, 2019

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@bedevere-bot
Copy link

bedevere-bot commented Oct 21, 2019

GH-16875 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit that referenced this pull request Oct 21, 2019
@miss-islington @serhiy-storchaka
bpo-31202: Preserve case of literal parts in Path.glob() on Windows. (G…
175abcc 
…H-16860)

(cherry picked from commit 10ecbad)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
miss-islington added a commit that referenced this pull request Oct 21, 2019
@miss-islington @serhiy-storchaka
bpo-31202: Preserve case of literal parts in Path.glob() on Windows. (G…
2f8d4f0 
…H-16860)

(cherry picked from commit 10ecbad)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
@serhiy-storchaka
bpo-31202: Preserve case of literal parts in Path.glob() on Windows. (p…
a6f5dc4 
…ythonGH-16860)
@brice-gros brice-gros mentioned this pull request Jan 23, 2020
Closed
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
@serhiy-storchaka @shihai1991
bpo-31202: Preserve case of literal parts in Path.glob() on Windows. (p…
d920504 
…ythonGH-16860)
@serhiy-storchaka serhiy-storchaka removed their assignment Dec 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zooba zooba

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@serhiy-storchaka @miss-islington @bedevere-bot @zooba @the-knights-who-say-ni