Correct the description of the 3.7 change in urllib.parse.quote #17065
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`~` is now treated as an unreserved character (i.e. it doesn't get quoted), not a reserved one.
|
Thanks for your time @SpecLad, and welcome to CPython! |
brandtbucher
approved these changes
Nov 6, 2019
There was a problem hiding this comment.
This looks good to me! Verified at: https://tools.ietf.org/html/rfc3986#section-2.3
taleinat
approved these changes
Nov 18, 2019
|
Thanks @SpecLad for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8. |
|
GH-17229 is a backport of this pull request to the 3.8 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 18, 2019
…onGH-17065) `~` is now treated as an unreserved character (i.e. it doesn't get quoted), not a reserved one. (cherry picked from commit f49f6ba) Co-authored-by: Роман Донченко <dpb@corrigendum.ru>
|
GH-17230 is a backport of this pull request to the 3.7 branch. |
|
Congrats on your first CPython contribution @SpecLad! 🍾 Looking forward to seeing more from you in the future. |
jacobneiltaylor
pushed a commit
to jacobneiltaylor/cpython
that referenced
this pull request
Dec 5, 2019
…onGH-17065) `~` is now treated as an unreserved character (i.e. it doesn't get quoted), not a reserved one.
shihai1991
pushed a commit
to shihai1991/cpython
that referenced
this pull request
Jan 31, 2020
…onGH-17065) `~` is now treated as an unreserved character (i.e. it doesn't get quoted), not a reserved one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
~is now treated as an unreserved character (i.e. it doesn't get quoted), not a reserved one.Automerge-Triggered-By: @taleinat