Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-36769: Document that fnmatch.filter supports any kind of iterable #13039

Merged
merged 4 commits into from Dec 18, 2020
Merged

bpo-36769: Document that fnmatch.filter supports any kind of iterable #13039

merged 4 commits into from Dec 18, 2020

Conversation

@andresdelfino
Copy link
Contributor

@andresdelfino andresdelfino commented May 1, 2019 •
edited by bedevere-bot

https://bugs.python.org/issue36769
auvipy
auvipy approved these changes May 2, 2019
View changes
@JulienPalard JulienPalard requested a review from csabella Sep 11, 2019
@JulienPalard
Copy link
Member

@JulienPalard JulienPalard commented Sep 11, 2019

@csabella would you please review the proper order of words in the proposed english sentence? As a french speaker I would have written Return a list of items in the *names* iterable but I have no idea if it's worse or better :]

@JulienPalard JulienPalard reopened this Sep 11, 2019
@JulienPalard
Copy link
Member

@JulienPalard JulienPalard commented Sep 11, 2019

(Closing and re-opening to give another chance to Travis, please ignore)

@andresdelfino
Copy link
Contributor Author

@andresdelfino andresdelfino commented Oct 16, 2019

@JulienPalard Cheryl isn't active on GitHub since July. Perhaps someone else can help us here?

@andresdelfino
Copy link
Contributor Author

@andresdelfino andresdelfino commented Jan 1, 2020

HI @csabella :) Could you review the proper order of words in the proposed English sentence, please?

csabella
csabella reviewed Jan 2, 2020
View changes
Doc/library/fnmatch.rst Outdated Show resolved Hide resolved
@JulienPalard JulienPalard merged commit e8d2264 into python:master Dec 18, 2020
10 checks passed
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Dec 18, 2020

@JulienPalard: Please replace # with GH- in the commit message next time. Thanks!

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Dec 18, 2020

Thanks @andresdelfino for the PR, and @JulienPalard for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Dec 18, 2020

Thanks @andresdelfino for the PR, and @JulienPalard for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

miss-islington added a commit to miss-islington/cpython that referenced this issue Dec 18, 2020
@andresdelfino @miss-islington
bpo-36769: Document that fnmatch.filter supports any kind of iterable (…
0d048ad 
…pythonGH-13039)

(cherry picked from commit e8d2264)

Co-authored-by: Andre Delfino <adelfino@gmail.com>
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Dec 18, 2020

GH-23845 is a backport of this pull request to the 3.9 branch.

miss-islington added a commit to miss-islington/cpython that referenced this issue Dec 18, 2020
@andresdelfino @miss-islington
bpo-36769: Document that fnmatch.filter supports any kind of iterable (…
c37e3d1 
…pythonGH-13039)

(cherry picked from commit e8d2264)

Co-authored-by: Andre Delfino <adelfino@gmail.com>
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Dec 18, 2020

GH-23846 is a backport of this pull request to the 3.8 branch.

@andresdelfino andresdelfino deleted the fnmatch.filter_supports_iterables branch Dec 18, 2020
miss-islington added a commit that referenced this issue Dec 18, 2020
@andresdelfino @miss-islington
bpo-36769: Document that fnmatch.filter supports any kind of iterable (…
4b412e8 
…GH-13039)

(cherry picked from commit e8d2264)

Co-authored-by: Andre Delfino <adelfino@gmail.com>
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jan 20, 2021

Thanks @andresdelfino for the PR, and @JulienPalard for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

miss-islington added a commit to miss-islington/cpython that referenced this issue Jan 20, 2021
@andresdelfino @miss-islington
bpo-36769: Document that fnmatch.filter supports any kind of iterable (…
1e4694a 
…pythonGH-13039)

(cherry picked from commit e8d2264)

Co-authored-by: Andre Delfino <adelfino@gmail.com>
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Jan 20, 2021

GH-24264 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit that referenced this issue Jan 20, 2021
@andresdelfino @miss-islington
bpo-36769: Document that fnmatch.filter supports any kind of iterable (…
8f334db 
…GH-13039)

(cherry picked from commit e8d2264)

Co-authored-by: Andre Delfino <adelfino@gmail.com>
adorilson added a commit to adorilson/cpython that referenced this issue Mar 13, 2021
@andresdelfino @adorilson
bpo-36769: Document that fnmatch.filter supports any kind of iterable (…
03c325d 
…python#13039)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iritkatriel iritkatriel

@csabella csabella

@JulienPalard JulienPalard

@auvipy auvipy

Assignees
No one assigned
Labels
CLA signed skip news type-documentation
Projects
None yet
Milestone
No milestone
8 participants
@andresdelfino @JulienPalard @bedevere-bot @miss-islington @iritkatriel @auvipy @csabella @the-knights-who-say-ni