Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upbpo-39019: Implement missing __class_getitem__ for subprocess classes #17558
Conversation
Thanks! Here are few comments. |
Misc/NEWS.d/next/Library/2019-12-07-18-58-44.bpo-38994.IJYhz_.rst
Outdated
Show resolved
Hide resolved
Misc/NEWS.d/next/Library/2019-12-10-21-03-34.bpo-39019.i8RpMZ.rst
Outdated
Show resolved
Hide resolved
LGTM! |
This comment has been minimized.
This comment has been minimized.
@gpshead I am going to merge this soon unless you are against it. |
4dc5a9d
into
python:master
This comment has been minimized.
This comment has been minimized.
bedevere-bot
commented
Dec 30, 2019
|
This comment has been minimized.
This comment has been minimized.
Unless I am missing something, the buildbot failure looks like a flake. |
isidentical commentedDec 10, 2019
•
edited by bedevere-bot
(It also includes a fix for a news entry from a previous PR, GH-17498)
https://bugs.python.org/issue39019