Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upbpo-39121: write gzip header OS information #17682
Conversation
This comment has been minimized.
This comment has been minimized.
the-knights-who-say-ni
commented
Dec 23, 2019
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). CLA MissingOur records indicate the following people have not signed the CLA: For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. If you have recently signed the CLA, please wait at least one business day You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
Misc/NEWS.d/next/Library/2019-12-23-03-21-38.bpo-39121.HgPaAz.rst
Outdated
Show resolved
Hide resolved
All changes implemented. |
@@ -17,6 +17,15 @@ | |||
|
|||
READ, WRITE = 1, 2 | |||
|
|||
# OS field values as specified in RFC 1952 | |||
OS_CODES = { |
This comment has been minimized.
This comment has been minimized.
corona10
Dec 27, 2019
•
Member
If values such as OS_CODES
does not intend to expose as the public constants.
I'd like to recommend to change OS_CODES
into _OS_CODES
also for OS_UNIX
, OS_NTFS
.
what do you think @serhiy-storchaka ?
This comment has been minimized.
This comment has been minimized.
wungad
Dec 27, 2019
Author
I agree. There is no need to expose them since they are specific to gzip header only.
wungad commentedDec 23, 2019
•
edited by bedevere-bot
https://bugs.python.org/issue39121