Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-37032: Document CodeType.replace (new in python 3.8) #17776

Merged
merged 1 commit into from Jan 1, 2020

Conversation

@asottile
Copy link
Contributor

asottile commented Jan 1, 2020

Doc/library/types.rst Outdated Show resolved Hide resolved
@asottile asottile force-pushed the asottile:codetype_replace_docs_37032 branch from 61a5cc5 to ba43b63 Jan 1, 2020
Copy link
Member

pablogsal left a comment

LGTM

@pablogsal pablogsal merged commit 22424c0 into python:master Jan 1, 2020
9 checks passed
9 checks passed
Docs
Details
Windows (x86)
Details
Windows (x64)
Details
macOS
Details
Ubuntu
Details
Azure Pipelines PR #20200101.5 succeeded
Details
bedevere/issue-number Issue number 37032 found
Details
bedevere/news "skip news" label found
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@miss-islington

This comment has been minimized.

Copy link

miss-islington commented Jan 1, 2020

Thanks @asottile for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒🤖

@bedevere-bot

This comment has been minimized.

Copy link

bedevere-bot commented Jan 1, 2020

GH-17779 is a backport of this pull request to the 3.8 branch.

@asottile asottile deleted the asottile:codetype_replace_docs_37032 branch Jan 1, 2020
miss-islington added a commit that referenced this pull request Jan 1, 2020
(cherry picked from commit 22424c0)

Co-authored-by: Anthony Sottile <asottile@umich.edu>
@vstinner

This comment has been minimized.

Copy link
Member

vstinner commented Jan 1, 2020

Thanks @asottile, I like how you documented it ;-) And it's good to have it in 3.8 branch as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.