Skip to content

/cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-38986: Make repr of C accelerated TaskWakeupMethWrapper the same as of pure Python version #17484

Merged
merged 1 commit into from Dec 7, 2019
Merged

bpo-38986: Make repr of C accelerated TaskWakeupMethWrapper the same as of pure Python version #17484

merged 1 commit into from Dec 7, 2019

Conversation

@asvetlov
Copy link
Contributor

asvetlov commented Dec 6, 2019 •
edited by bedevere-bot

https://bugs.python.org/issue38986
@asvetlov
Make repr of C accelerated TaskWakeupMethWrapper the same as of pure …
Loading status checks…
0ed45d0 
…Python version
@asvetlov asvetlov requested a review from 1st1 as a code owner Dec 6, 2019
@asvetlov asvetlov merged commit 969ae7a into python:master Dec 7, 2019
4 checks passed
4 checks passed
Azure Pipelines PR #20191206.8 succeeded
Details
bedevere/issue-number Issue number 38986 found
Details
bedevere/news News entry found in Misc/NEWS.d
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@asvetlov asvetlov deleted the asvetlov:reprs branch Dec 7, 2019
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Dec 7, 2019

Thanks @asvetlov for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖
miss-islington added a commit to miss-islington/cpython that referenced this pull request Dec 7, 2019
@asvetlov @miss-islington
Make repr of C accelerated TaskWakeupMethWrapper the same as of pure …
fb3f37d 
…Python version (pythonGH-17484)

(cherry picked from commit 969ae7a)

Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com>
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Dec 7, 2019

GH-17493 is a backport of this pull request to the 3.8 branch.
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Dec 7, 2019

Sorry, @asvetlov, I could not cleanly backport this to 3.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 969ae7aca809a8dacafee04c261110eea0ac1945 3.7
@asvetlov asvetlov mentioned this pull request Dec 7, 2019
Merged
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Dec 7, 2019

GH-17494 is a backport of this pull request to the 3.7 branch.
miss-islington added a commit that referenced this pull request Dec 7, 2019
@miss-islington @asvetlov
Make repr of C accelerated TaskWakeupMethWrapper the same as of pure …
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
ce0a2a8 
…Python version (GH-17484)

(cherry picked from commit 969ae7a)

Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com>
asvetlov added a commit that referenced this pull request Dec 7, 2019
@asvetlov
[3.7] Make repr of C accelerated TaskWakeupMethWrapper the same as of…
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
8ce85a3 
… pure Python version (GH-17484) (GH-17494)

(cherry picked from commit 969ae7a)

Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1st1 1st1

Assignees

@asvetlov asvetlov

Labels
CLA signed expert-asyncio
Projects
None yet
Milestone
No milestone
4 participants
@asvetlov @miss-islington @bedevere-bot @the-knights-who-say-ni
You can’t perform that action at this time.