Skip to content

/cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.8] bpo-38588: Fix possible crashes in dict and list when calling P… #17764

Merged
merged 2 commits into from Dec 31, 2019
Merged

[3.8] bpo-38588: Fix possible crashes in dict and list when calling P… #17764

merged 2 commits into from Dec 31, 2019

Conversation

@corona10
Copy link
Member

corona10 commented Dec 31, 2019 •
edited by bedevere-bot

…yObject_RichCompareBool (GH-17734)

Take strong references before calling PyObject_RichCompareBool to protect against the case
where the object dies during the call.
(cherry picked from commit 2d5bf56)

Co-authored-by: Dong-hee Na donghee.na92@gmail.com

https://bugs.python.org/issue38588
@corona10
[3.8] bpo-38588: Fix possible crashes in dict and list when calling P…
Loading status checks…
6a341a7 
…yObject_RichCompareBool (GH-17734)

Take strong references before calling PyObject_RichCompareBool to protect against the case
where the object dies during the call.
(cherry picked from commit 2d5bf56)

Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>
@corona10 corona10 requested a review from methane as a code owner Dec 31, 2019
@bedevere-bot bedevere-bot mentioned this pull request Dec 31, 2019
Merged
@corona10 corona10 requested a review from pablogsal Dec 31, 2019
@methane
methane reviewed Dec 31, 2019
View changes
Objects/listobject.c Show resolved Hide resolved
@corona10 @methane
Update Objects/listobject.c
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
ebb9e7e 
@methane's suggestion

Co-Authored-By: Inada Naoki <songofacandy@gmail.com>
@corona10 corona10 requested a review from methane Dec 31, 2019
@methane
methane approved these changes Dec 31, 2019
View changes
@pablogsal pablogsal merged commit 2ee8791 into python:3.8 Dec 31, 2019
5 checks passed
5 checks passed
Azure Pipelines PR #20191231.5 succeeded
Details
bedevere/issue-number Issue number 38588 found
Details
bedevere/maintenance-branch-pr Valid maintenance branch PR title.
bedevere/news News entry found in Misc/NEWS.d
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@corona10 corona10 deleted the corona10:backport-2d5bf56-3.8 branch Dec 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@methane methane

@pablogsal pablogsal

Assignees
No one assigned
Labels
CLA signed
Projects
None yet
Milestone
No milestone
5 participants
@corona10 @methane @pablogsal @the-knights-who-say-ni @bedevere-bot
You can’t perform that action at this time.