Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-39019: Implement missing __class_getitem__ for SpooledTemporaryFile #17560

Merged
merged 5 commits into from Dec 30, 2019

Conversation

@isidentical
Copy link
Contributor

isidentical commented Dec 10, 2019

isidentical added 2 commits Dec 25, 2019
Copy link
Contributor

ilevkivskyi left a comment

Thanks! Here are couple comments.

Lib/tempfile.py Show resolved Hide resolved
@isidentical isidentical force-pushed the isidentical:bpo-39019-2 branch from fc219b7 to 5f6343e Dec 27, 2019
Lib/tempfile.py Outdated Show resolved Hide resolved
Copy link
Contributor

ilevkivskyi left a comment

LGTM!

@ilevkivskyi ilevkivskyi merged commit 09c482f into python:master Dec 30, 2019
9 checks passed
9 checks passed
Docs
Details
Windows (x86)
Details
Windows (x64)
Details
macOS
Details
Ubuntu
Details
Azure Pipelines PR #20191227.18 succeeded
Details
bedevere/issue-number Issue number 39019 found
Details
bedevere/news News entry found in Misc/NEWS.d
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.