Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upbpo-38314: Add is_reading() method to asyncio _UnixReadPipeTransport #17755
+122
−0
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
callumquick commentedDec 30, 2019
•
edited by bedevere-bot
Unix read pipe (from
Lib:asyncio.unix_events) is missingis_reading()method available for other read transports within the asyncio protocol, which checks that the transport read is notpaused or the transport is not closing.
This behaviour is documented in
Doc/library/asyncio-protocol.rst.Additional tests for the
Lib:asyncio.unix_eventsmodule which check against the state of the pipe and the behaviour ofis_reading(). New testing harness for functional testing of the UNIX pipe connection and associated methods, with an initial test for the newis_reading()implementation.This is a fresh rebase PR, based on changes made in the original PR (#17042).
https://bugs.python.org/issue38314