Skip to content

/cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-27593: Updates Windows build to use information from git #262

Merged
merged 4 commits into from Mar 4, 2017
Merged

bpo-27593: Updates Windows build to use information from git #262

merged 4 commits into from Mar 4, 2017
+18 −18

Conversation

@zooba
Copy link
Member

zooba commented Feb 23, 2017 •
edited

bpo-27593: Updates Windows build to use information from git
Note that until getbuildinfo.c has been updated, this won't make things work any better.
@zooba
bpo-27593: Updates Windows build to use information from git
Loading status checks…
992f5d7 
Note that until getbuildinfo.c has not been updated, this won't make things work any better.
@ned-deily ned-deily self-requested a review Feb 23, 2017
@zooba
Removes GITTAG variable from Windows build.
Loading status checks…
e5555d4
@ned-deily
ned-deily requested changes Mar 4, 2017
View changes
Copy link
Member

ned-deily left a comment

In #446, I've advocated retaining tag information like was the case with hg, so, if we agree on that, this PR would need to be changed to also supply GITTAG.
@zooba
Revert "Removes GITTAG variable from Windows build."
Loading status checks…
61f1a3f 
This reverts commit e5555d4.
@zooba

This comment has been minimized.

Sign in to view
Copy link
Member Author

zooba commented Mar 4, 2017

@ned-deily I have no strong opinion about including the tag - @brettcannon thought it wasn't important.

I've reverted the change to exclude it here, so our PRs are consistent. I see no harm in releasing RC with it included and changing that for final if we want to.
@zooba
Changes command for getting the branch.
Loading status checks…
a86b42e
@ned-deily
ned-deily approved these changes Mar 4, 2017
View changes
@zooba zooba merged commit a0c07d2 into python:master Mar 4, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
zooba added a commit to zooba/cpython that referenced this pull request Mar 4, 2017
@zooba
bpo-27593: Updates Windows build to use information from git (python#262
9fa054d 
)

* bpo-27593: Updates Windows build to use information from git
zooba added a commit to zooba/cpython that referenced this pull request Mar 4, 2017
@zooba
bpo-27593: Updates Windows build to use information from git (python#262
fcee3c1 
)

* bpo-27593: Updates Windows build to use information from git
zooba added a commit to zooba/cpython that referenced this pull request Mar 4, 2017
@zooba
bpo-27593: Updates Windows build to use information from git (python#262
54f3124 
)

* bpo-27593: Updates Windows build to use information from git
zooba added a commit that referenced this pull request Mar 4, 2017
@zooba
bpo-27593: Updates Windows build to use information from git (#262) (#…
Loading status checks…
d3e1e9d 
…450)

* bpo-27593: Updates Windows build to use information from git
zooba added a commit that referenced this pull request Mar 4, 2017
@zooba
bpo-27593: Updates Windows build to use information from git (#262) (#…
Loading status checks…
cf445f1 
…449)

* bpo-27593: Updates Windows build to use information from git
zooba added a commit that referenced this pull request Mar 4, 2017
@zooba
bpo-27593: Updates Windows build to use information from git (#262) (#…
Loading status checks…
6120484 
…448)

* bpo-27593: Updates Windows build to use information from git (#262)

* bpo-27593: Updates Windows build to use information from git

* Fixes git command (#451)
@zooba zooba deleted the zooba:bpo-27593 branch May 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ned-deily ned-deily

Assignees
No one assigned
Labels
CLA signed
Projects
None yet
Milestone
No milestone
4 participants
@zooba @ned-deily @Mariatta @the-knights-who-say-ni
You can’t perform that action at this time.