Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-39144 Align ctags and etags behaviours and include Python stdlib files #17721

Merged
merged 5 commits into from Dec 28, 2019

Conversation

@tonybaloney
Copy link
Contributor

tonybaloney commented Dec 27, 2019

  • make tags and make TAGS to both include Python standard library files
  • make TAGS to reset tags file, as make tags does (implicitly)
  • make TAGS to include Modules/_ctypes as make tags does

https://bugs.python.org/issue39144

- make TAGS to reset tags file
- make TAGS to include Modules/_ctypes
@tonybaloney tonybaloney changed the title bpo-- make tags and make TAGS to both include Python standard library files bpo-39144 Align ctags and etags behaviours and include Python stdlib files Dec 27, 2019
@@ -1730,13 +1730,17 @@ tags::
ctags -w $(srcdir)/Include/*.h $(srcdir)/Include/cpython/*.h $(srcdir)/Include/internal/*.h
for i in $(SRCDIRS); do ctags -f tags -w -a $(srcdir)/$$i/*.[ch]; done
ctags -f tags -w -a $(srcdir)/Modules/_ctypes/*.[ch]
find $(srcdir)/Lib -type f -name "*.py" -not -name "test_*.py" -not -path "*/test/*" | ctags -f tags -w -a -L -

This comment has been minimized.

Copy link
@pablogsal

pablogsal Dec 27, 2019

Member

This still will pick up some stuff that is not likely wanted, for example, the contents of Lib/lib2to3/tests. Also, some packages have the test folder inside like Lib/unittest/test/.

This comment has been minimized.

Copy link
@tonybaloney

tonybaloney Dec 27, 2019

Author Contributor

It will exclude them in 4681826

LC_ALL=C sort -o tags tags

# Create a tags file for GNU Emacs
TAGS::
touch tags

This comment has been minimized.

Copy link
@pablogsal

pablogsal Dec 27, 2019

Member

Why do you need this line? If I invoke the makefile from another place won't this create a 'tags' file in my current working directory?

This comment has been minimized.

Copy link
@tonybaloney

tonybaloney Dec 27, 2019

Author Contributor

etags -a appends to the current tags, (regardless of whats in it), if you run make tags and make TAGS you'll end up with a corrupted file.
the make tags commands will find the first pass without the -a append, so it resets the file. I'll update this to run in a different order

This comment has been minimized.

Copy link
@tonybaloney

tonybaloney Dec 27, 2019

Author Contributor

Updated in 7e31b49

tonybaloney added 3 commits Dec 27, 2019
Exclude /*_test/ and /tests/ directories
@tonybaloney

This comment has been minimized.

Copy link
Contributor Author

tonybaloney commented Dec 27, 2019

@pablogsal please re-review

@tonybaloney

This comment has been minimized.

Copy link
Contributor Author

tonybaloney commented Dec 27, 2019

For reference, these are the files that will be indexed by find ./Lib -type f -name "*.py" -not -name "test_*.py" -not -path "*/test/*" -not -path "*/tests/*" -not -path "*/*_test/*"

./Lib/zipfile.py
./Lib/shutil.py
./Lib/tempfile.py
./Lib/encodings/mac_romanian.py
./Lib/encodings/mac_farsi.py
./Lib/encodings/idna.py
./Lib/encodings/cp273.py
./Lib/encodings/punycode.py
./Lib/encodings/raw_unicode_escape.py
./Lib/encodings/utf_8.py
./Lib/encodings/cp1252.py
./Lib/encodings/cp869.py
./Lib/encodings/iso8859_14.py
./Lib/encodings/iso8859_2.py
./Lib/encodings/mac_arabic.py
./Lib/encodings/mac_croatian.py
./Lib/encodings/big5hkscs.py
./Lib/encodings/cp1256.py
./Lib/encodings/iso8859_6.py
./Lib/encodings/iso8859_10.py
./Lib/encodings/iso2022_kr.py
./Lib/encodings/cp1140.py
./Lib/encodings/cp1125.py
./Lib/encodings/iso2022_jp_1.py
./Lib/encodings/cp1257.py
./Lib/encodings/cp949.py
./Lib/encodings/cp858.py
./Lib/encodings/iso8859_7.py
./Lib/encodings/iso8859_11.py
./Lib/encodings/hp_roman8.py
./Lib/encodings/koi8_r.py
./Lib/encodings/zlib_codec.py
./Lib/encodings/gbk.py
./Lib/encodings/johab.py
./Lib/encodings/cp1253.py
./Lib/encodings/iso8859_15.py
./Lib/encodings/iso2022_jp_2004.py
./Lib/encodings/mac_iceland.py
./Lib/encodings/iso8859_3.py
./Lib/encodings/mac_greek.py
./Lib/encodings/rot_13.py
./Lib/encodings/utf_16_be.py
./Lib/encodings/euc_kr.py
./Lib/encodings/euc_jisx0213.py
./Lib/encodings/cp863.py
./Lib/encodings/ascii.py
./Lib/encodings/iso8859_8.py
./Lib/encodings/cp857.py
./Lib/encodings/utf_32_be.py
./Lib/encodings/cp1258.py
./Lib/encodings/oem.py
./Lib/encodings/mac_latin2.py
./Lib/encodings/cp775.py
./Lib/encodings/mac_roman.py
./Lib/encodings/__init__.py
./Lib/encodings/cp852.py
./Lib/encodings/shift_jisx0213.py
./Lib/encodings/cp866.py
./Lib/encodings/utf_7.py
./Lib/encodings/base64_codec.py
./Lib/encodings/cp932.py
./Lib/encodings/cp720.py
./Lib/encodings/cp862.py
./Lib/encodings/cp437.py
./Lib/encodings/palmos.py
./Lib/encodings/iso8859_9.py
./Lib/encodings/cp856.py
./Lib/encodings/aliases.py
./Lib/encodings/latin_1.py
./Lib/encodings/cp875.py
./Lib/encodings/cp950.py
./Lib/encodings/unicode_escape.py
./Lib/encodings/cp737.py
./Lib/encodings/cp865.py
./Lib/encodings/ptcp154.py
./Lib/encodings/big5.py
./Lib/encodings/cp424.py
./Lib/encodings/cp861.py
./Lib/encodings/euc_jp.py
./Lib/encodings/cp855.py
./Lib/encodings/shift_jis.py
./Lib/encodings/utf_32_le.py
./Lib/encodings/cp500.py
./Lib/encodings/undefined.py
./Lib/encodings/cp860.py
./Lib/encodings/uu_codec.py
./Lib/encodings/utf_16_le.py
./Lib/encodings/gb18030.py
./Lib/encodings/cp874.py
./Lib/encodings/cp850.py
./Lib/encodings/cp864.py
./Lib/encodings/utf_32.py
./Lib/encodings/koi8_u.py
./Lib/encodings/cp1254.py
./Lib/encodings/iso2022_jp_2.py
./Lib/encodings/utf_16.py
./Lib/encodings/iso8859_4.py
./Lib/encodings/euc_jis_2004.py
./Lib/encodings/mbcs.py
./Lib/encodings/cp1250.py
./Lib/encodings/gb2312.py
./Lib/encodings/iso8859_16.py
./Lib/encodings/mac_cyrillic.py
./Lib/encodings/hex_codec.py
./Lib/encodings/tis_620.py
./Lib/encodings/cp037.py
./Lib/encodings/cp1006.py
./Lib/encodings/cp1251.py
./Lib/encodings/mac_turkish.py
./Lib/encodings/iso2022_jp_ext.py
./Lib/encodings/iso8859_1.py
./Lib/encodings/hz.py
./Lib/encodings/bz2_codec.py
./Lib/encodings/quopri_codec.py
./Lib/encodings/kz1048.py
./Lib/encodings/utf_8_sig.py
./Lib/encodings/koi8_t.py
./Lib/encodings/cp1255.py
./Lib/encodings/iso2022_jp_3.py
./Lib/encodings/shift_jis_2004.py
./Lib/encodings/cp1026.py
./Lib/encodings/charmap.py
./Lib/encodings/iso8859_5.py
./Lib/encodings/iso8859_13.py
./Lib/encodings/iso2022_jp.py
./Lib/queue.py
./Lib/_pyio.py
./Lib/crypt.py
./Lib/pkgutil.py
./Lib/distutils/_msvccompiler.py
./Lib/distutils/unixccompiler.py
./Lib/distutils/filelist.py
./Lib/distutils/ccompiler.py
./Lib/distutils/msvc9compiler.py
./Lib/distutils/archive_util.py
./Lib/distutils/cmd.py
./Lib/distutils/config.py
./Lib/distutils/version.py
./Lib/distutils/log.py
./Lib/distutils/util.py
./Lib/distutils/fancy_getopt.py
./Lib/distutils/versionpredicate.py
./Lib/distutils/__init__.py
./Lib/distutils/file_util.py
./Lib/distutils/core.py
./Lib/distutils/cygwinccompiler.py
./Lib/distutils/extension.py
./Lib/distutils/debug.py
./Lib/distutils/spawn.py
./Lib/distutils/text_file.py
./Lib/distutils/msvccompiler.py
./Lib/distutils/errors.py
./Lib/distutils/dep_util.py
./Lib/distutils/command/build.py
./Lib/distutils/command/build_ext.py
./Lib/distutils/command/config.py
./Lib/distutils/command/clean.py
./Lib/distutils/command/check.py
./Lib/distutils/command/install_scripts.py
./Lib/distutils/command/upload.py
./Lib/distutils/command/register.py
./Lib/distutils/command/bdist_wininst.py
./Lib/distutils/command/install_headers.py
./Lib/distutils/command/install_lib.py
./Lib/distutils/command/build_py.py
./Lib/distutils/command/bdist_dumb.py
./Lib/distutils/command/__init__.py
./Lib/distutils/command/sdist.py
./Lib/distutils/command/bdist.py
./Lib/distutils/command/build_scripts.py
./Lib/distutils/command/bdist_rpm.py
./Lib/distutils/command/build_clib.py
./Lib/distutils/command/install.py
./Lib/distutils/command/bdist_msi.py
./Lib/distutils/command/install_egg_info.py
./Lib/distutils/command/install_data.py
./Lib/distutils/dir_util.py
./Lib/distutils/sysconfig.py
./Lib/distutils/dist.py
./Lib/distutils/bcppcompiler.py
./Lib/lzma.py
./Lib/asyncore.py
./Lib/__phello__.foo.py
./Lib/_sitebuiltins.py
./Lib/copyreg.py
./Lib/sndhdr.py
./Lib/rlcompleter.py
./Lib/gzip.py
./Lib/ctypes/_aix.py
./Lib/ctypes/wintypes.py
./Lib/ctypes/util.py
./Lib/ctypes/__init__.py
./Lib/ctypes/_endian.py
./Lib/ctypes/macholib/dyld.py
./Lib/ctypes/macholib/framework.py
./Lib/ctypes/macholib/__init__.py
./Lib/ctypes/macholib/dylib.py
./Lib/ipaddress.py
./Lib/trace.py
./Lib/webbrowser.py
./Lib/nntplib.py
./Lib/_compat_pickle.py
./Lib/unittest/signals.py
./Lib/unittest/runner.py
./Lib/unittest/suite.py
./Lib/unittest/util.py
./Lib/unittest/__init__.py
./Lib/unittest/result.py
./Lib/unittest/loader.py
./Lib/unittest/case.py
./Lib/unittest/main.py
./Lib/unittest/async_case.py
./Lib/unittest/__main__.py
./Lib/unittest/mock.py
./Lib/dis.py
./Lib/formatter.py
./Lib/bdb.py
./Lib/zipapp.py
./Lib/cmd.py
./Lib/tty.py
./Lib/curses/textpad.py
./Lib/curses/ascii.py
./Lib/curses/__init__.py
./Lib/curses/has_key.py
./Lib/curses/panel.py
./Lib/tabnanny.py
./Lib/_py_abc.py
./Lib/cProfile.py
./Lib/zipimport.py
./Lib/token.py
./Lib/textwrap.py
./Lib/base64.py
./Lib/_markupbase.py
./Lib/bz2.py
./Lib/signal.py
./Lib/sre_constants.py
./Lib/cgitb.py
./Lib/_aix_support.py
./Lib/_threading_local.py
./Lib/pyclbr.py
./Lib/gettext.py
./Lib/wave.py
./Lib/weakref.py
./Lib/bisect.py
./Lib/opcode.py
./Lib/netrc.py
./Lib/heapq.py
./Lib/functools.py
./Lib/modulefinder.py
./Lib/_compression.py
./Lib/tracemalloc.py
./Lib/hashlib.py
./Lib/cgi.py
./Lib/codeop.py
./Lib/turtledemo/tree.py
./Lib/turtledemo/round_dance.py
./Lib/turtledemo/colormixer.py
./Lib/turtledemo/bytedesign.py
./Lib/turtledemo/chaos.py
./Lib/turtledemo/clock.py
./Lib/turtledemo/sorting_animate.py
./Lib/turtledemo/paint.py
./Lib/turtledemo/__init__.py
./Lib/turtledemo/lindenmayer.py
./Lib/turtledemo/penrose.py
./Lib/turtledemo/peace.py
./Lib/turtledemo/rosette.py
./Lib/turtledemo/nim.py
./Lib/turtledemo/yinyang.py
./Lib/turtledemo/fractalcurves.py
./Lib/turtledemo/planet_and_moon.py
./Lib/turtledemo/forest.py
./Lib/turtledemo/two_canvases.py
./Lib/turtledemo/__main__.py
./Lib/turtledemo/minimal_hanoi.py
./Lib/fnmatch.py
./Lib/multiprocessing/dummy/__init__.py
./Lib/multiprocessing/dummy/connection.py
./Lib/multiprocessing/queues.py
./Lib/multiprocessing/heap.py
./Lib/multiprocessing/shared_memory.py
./Lib/multiprocessing/resource_tracker.py
./Lib/multiprocessing/reduction.py
./Lib/multiprocessing/util.py
./Lib/multiprocessing/popen_spawn_win32.py
./Lib/multiprocessing/__init__.py
./Lib/multiprocessing/forkserver.py
./Lib/multiprocessing/connection.py
./Lib/multiprocessing/context.py
./Lib/multiprocessing/spawn.py
./Lib/multiprocessing/synchronize.py
./Lib/multiprocessing/process.py
./Lib/multiprocessing/sharedctypes.py
./Lib/multiprocessing/popen_fork.py
./Lib/multiprocessing/pool.py
./Lib/multiprocessing/popen_forkserver.py
./Lib/multiprocessing/popen_spawn_posix.py
./Lib/multiprocessing/managers.py
./Lib/multiprocessing/resource_sharer.py
./Lib/traceback.py
./Lib/nturl2path.py
./Lib/warnings.py
./Lib/subprocess.py
./Lib/profile.py
./Lib/imghdr.py
./Lib/this.py
./Lib/filecmp.py
./Lib/msilib/sequence.py
./Lib/msilib/__init__.py
./Lib/msilib/text.py
./Lib/msilib/schema.py
./Lib/codecs.py
./Lib/urllib/error.py
./Lib/urllib/request.py
./Lib/urllib/__init__.py
./Lib/urllib/response.py
./Lib/urllib/robotparser.py
./Lib/urllib/parse.py
./Lib/uu.py
./Lib/_weakrefset.py
./Lib/io.py
./Lib/code.py
./Lib/operator.py
./Lib/fileinput.py
./Lib/os.py
./Lib/difflib.py
./Lib/pydoc.py
./Lib/__init__.py
./Lib/symbol.py
./Lib/selectors.py
./Lib/decimal.py
./Lib/socketserver.py
./Lib/copy.py
./Lib/html/__init__.py
./Lib/html/parser.py
./Lib/html/entities.py
./Lib/genericpath.py
./Lib/linecache.py
./Lib/types.py
./Lib/tkinter/scrolledtext.py
./Lib/tkinter/colorchooser.py
./Lib/tkinter/commondialog.py
./Lib/tkinter/messagebox.py
./Lib/tkinter/dialog.py
./Lib/tkinter/constants.py
./Lib/tkinter/dnd.py
./Lib/tkinter/__init__.py
./Lib/tkinter/ttk.py
./Lib/tkinter/filedialog.py
./Lib/tkinter/font.py
./Lib/tkinter/tix.py
./Lib/tkinter/__main__.py
./Lib/tkinter/simpledialog.py
./Lib/mimetypes.py
./Lib/xdrlib.py
./Lib/colorsys.py
./Lib/numbers.py
./Lib/_strptime.py
./Lib/contextvars.py
./Lib/random.py
./Lib/ftplib.py
./Lib/chunk.py
./Lib/optparse.py
./Lib/xml/parsers/expat.py
./Lib/xml/parsers/__init__.py
./Lib/xml/sax/handler.py
./Lib/xml/sax/__init__.py
./Lib/xml/sax/saxutils.py
./Lib/xml/sax/xmlreader.py
./Lib/xml/sax/expatreader.py
./Lib/xml/sax/_exceptions.py
./Lib/xml/__init__.py
./Lib/xml/dom/pulldom.py
./Lib/xml/dom/expatbuilder.py
./Lib/xml/dom/domreg.py
./Lib/xml/dom/minicompat.py
./Lib/xml/dom/__init__.py
./Lib/xml/dom/NodeFilter.py
./Lib/xml/dom/xmlbuilder.py
./Lib/xml/dom/minidom.py
./Lib/xml/etree/ElementPath.py
./Lib/xml/etree/cElementTree.py
./Lib/xml/etree/__init__.py
./Lib/xml/etree/ElementInclude.py
./Lib/xml/etree/ElementTree.py
./Lib/pdb.py
./Lib/threading.py
./Lib/turtle.py
./Lib/platform.py
./Lib/pstats.py
./Lib/glob.py
./Lib/quopri.py
./Lib/symtable.py
./Lib/pprint.py
./Lib/calendar.py
./Lib/inspect.py
./Lib/wsgiref/util.py
./Lib/wsgiref/handlers.py
./Lib/wsgiref/__init__.py
./Lib/wsgiref/validate.py
./Lib/wsgiref/simple_server.py
./Lib/wsgiref/headers.py
./Lib/poplib.py
./Lib/binhex.py
./Lib/plistlib.py
./Lib/pickletools.py
./Lib/pipes.py
./Lib/site.py
./Lib/json/decoder.py
./Lib/json/scanner.py
./Lib/json/__init__.py
./Lib/json/encoder.py
./Lib/json/tool.py
./Lib/telnetlib.py
./Lib/keyword.py
./Lib/configparser.py
./Lib/reprlib.py
./Lib/secrets.py
./Lib/shlex.py
./Lib/http/cookies.py
./Lib/http/server.py
./Lib/http/client.py
./Lib/http/__init__.py
./Lib/http/cookiejar.py
./Lib/sqlite3/__init__.py
./Lib/sqlite3/dump.py
./Lib/sqlite3/dbapi2.py
./Lib/posixpath.py
./Lib/py_compile.py
./Lib/ensurepip/__init__.py
./Lib/ensurepip/_bundled/__init__.py
./Lib/ensurepip/__main__.py
./Lib/ensurepip/_uninstall.py
./Lib/_osx_support.py
./Lib/stat.py
./Lib/compileall.py
./Lib/concurrent/futures/_base.py
./Lib/concurrent/futures/thread.py
./Lib/concurrent/futures/__init__.py
./Lib/concurrent/futures/process.py
./Lib/concurrent/__init__.py
./Lib/csv.py
./Lib/fractions.py
./Lib/sched.py
./Lib/imaplib.py
./Lib/mailbox.py
./Lib/sre_compile.py
./Lib/locale.py
./Lib/ast.py
./Lib/doctest.py
./Lib/argparse.py
./Lib/getpass.py
./Lib/pickle.py
./Lib/pty.py
./Lib/contextlib.py
./Lib/statistics.py
./Lib/_collections_abc.py
./Lib/sunau.py
./Lib/__future__.py
./Lib/dataclasses.py
./Lib/shelve.py
./Lib/string.py
./Lib/smtplib.py
./Lib/venv/__init__.py
./Lib/venv/__main__.py
./Lib/getopt.py
./Lib/antigravity.py
./Lib/enum.py
./Lib/dbm/ndbm.py
./Lib/dbm/gnu.py
./Lib/dbm/__init__.py
./Lib/dbm/dumb.py
./Lib/timeit.py
./Lib/hmac.py
./Lib/tarfile.py
./Lib/importlib/metadata.py
./Lib/importlib/util.py
./Lib/importlib/_bootstrap.py
./Lib/importlib/__init__.py
./Lib/importlib/_bootstrap_external.py
./Lib/importlib/resources.py
./Lib/importlib/machinery.py
./Lib/importlib/abc.py
./Lib/xmlrpc/server.py
./Lib/xmlrpc/client.py
./Lib/xmlrpc/__init__.py
./Lib/stringprep.py
./Lib/typing.py
./Lib/lib2to3/fixes/fix_throw.py
./Lib/lib2to3/fixes/fix_print.py
./Lib/lib2to3/fixes/fix_input.py
./Lib/lib2to3/fixes/fix_buffer.py
./Lib/lib2to3/fixes/fix_paren.py
./Lib/lib2to3/fixes/fix_exec.py
./Lib/lib2to3/fixes/fix_filter.py
./Lib/lib2to3/fixes/fix_unicode.py
./Lib/lib2to3/fixes/fix_ne.py
./Lib/lib2to3/fixes/fix_nonzero.py
./Lib/lib2to3/fixes/fix_sys_exc.py
./Lib/lib2to3/fixes/fix_zip.py
./Lib/lib2to3/fixes/fix_map.py
./Lib/lib2to3/fixes/fix_imports2.py
./Lib/lib2to3/fixes/fix_metaclass.py
./Lib/lib2to3/fixes/fix_except.py
./Lib/lib2to3/fixes/fix_apply.py
./Lib/lib2to3/fixes/fix_set_literal.py
./Lib/lib2to3/fixes/fix_getcwdu.py
./Lib/lib2to3/fixes/fix_urllib.py
./Lib/lib2to3/fixes/fix_future.py
./Lib/lib2to3/fixes/fix_operator.py
./Lib/lib2to3/fixes/fix_imports.py
./Lib/lib2to3/fixes/__init__.py
./Lib/lib2to3/fixes/fix_standarderror.py
./Lib/lib2to3/fixes/fix_renames.py
./Lib/lib2to3/fixes/fix_tuple_params.py
./Lib/lib2to3/fixes/fix_idioms.py
./Lib/lib2to3/fixes/fix_raw_input.py
./Lib/lib2to3/fixes/fix_methodattrs.py
./Lib/lib2to3/fixes/fix_itertools_imports.py
./Lib/lib2to3/fixes/fix_long.py
./Lib/lib2to3/fixes/fix_raise.py
./Lib/lib2to3/fixes/fix_dict.py
./Lib/lib2to3/fixes/fix_reload.py
./Lib/lib2to3/fixes/fix_funcattrs.py
./Lib/lib2to3/fixes/fix_reduce.py
./Lib/lib2to3/fixes/fix_intern.py
./Lib/lib2to3/fixes/fix_import.py
./Lib/lib2to3/fixes/fix_next.py
./Lib/lib2to3/fixes/fix_basestring.py
./Lib/lib2to3/fixes/fix_asserts.py
./Lib/lib2to3/fixes/fix_execfile.py
./Lib/lib2to3/fixes/fix_has_key.py
./Lib/lib2to3/fixes/fix_repr.py
./Lib/lib2to3/fixes/fix_numliterals.py
./Lib/lib2to3/fixes/fix_isinstance.py
./Lib/lib2to3/fixes/fix_types.py
./Lib/lib2to3/fixes/fix_xreadlines.py
./Lib/lib2to3/fixes/fix_itertools.py
./Lib/lib2to3/fixes/fix_exitfunc.py
./Lib/lib2to3/fixes/fix_ws_comma.py
./Lib/lib2to3/fixes/fix_xrange.py
./Lib/lib2to3/refactor.py
./Lib/lib2to3/fixer_base.py
./Lib/lib2to3/__init__.py
./Lib/lib2to3/btm_utils.py
./Lib/lib2to3/pygram.py
./Lib/lib2to3/patcomp.py
./Lib/lib2to3/main.py
./Lib/lib2to3/pgen2/token.py
./Lib/lib2to3/pgen2/pgen.py
./Lib/lib2to3/pgen2/__init__.py
./Lib/lib2to3/pgen2/literals.py
./Lib/lib2to3/pgen2/grammar.py
./Lib/lib2to3/pgen2/conv.py
./Lib/lib2to3/pgen2/parse.py
./Lib/lib2to3/pgen2/driver.py
./Lib/lib2to3/pgen2/tokenize.py
./Lib/lib2to3/__main__.py
./Lib/lib2to3/fixer_util.py
./Lib/lib2to3/btm_matcher.py
./Lib/lib2to3/pytree.py
./Lib/idlelib/multicall.py
./Lib/idlelib/idle.py
./Lib/idlelib/mainmenu.py
./Lib/idlelib/filelist.py
./Lib/idlelib/sidebar.py
./Lib/idlelib/tree.py
./Lib/idlelib/pyshell.py
./Lib/idlelib/stackviewer.py
./Lib/idlelib/statusbar.py
./Lib/idlelib/run.py
./Lib/idlelib/autoexpand.py
./Lib/idlelib/codecontext.py
./Lib/idlelib/configdialog.py
./Lib/idlelib/config.py
./Lib/idlelib/help_about.py
./Lib/idlelib/debugobj.py
./Lib/idlelib/query.py
./Lib/idlelib/window.py
./Lib/idlelib/searchbase.py
./Lib/idlelib/colorizer.py
./Lib/idlelib/redirector.py
./Lib/idlelib/config_key.py
./Lib/idlelib/calltip_w.py
./Lib/idlelib/runscript.py
./Lib/idlelib/delegator.py
./Lib/idlelib/__init__.py
./Lib/idlelib/format.py
./Lib/idlelib/textview.py
./Lib/idlelib/grep.py
./Lib/idlelib/tooltip.py
./Lib/idlelib/pathbrowser.py
./Lib/idlelib/debugger.py
./Lib/idlelib/browser.py
./Lib/idlelib/pyparse.py
./Lib/idlelib/macosx.py
./Lib/idlelib/scrolledlist.py
./Lib/idlelib/searchengine.py
./Lib/idlelib/rpc.py
./Lib/idlelib/percolator.py
./Lib/idlelib/outwin.py
./Lib/idlelib/undo.py
./Lib/idlelib/squeezer.py
./Lib/idlelib/iomenu.py
./Lib/idlelib/zoomheight.py
./Lib/idlelib/search.py
./Lib/idlelib/debugger_r.py
./Lib/idlelib/editor.py
./Lib/idlelib/dynoption.py
./Lib/idlelib/autocomplete_w.py
./Lib/idlelib/calltip.py
./Lib/idlelib/autocomplete.py
./Lib/idlelib/hyperparser.py
./Lib/idlelib/help.py
./Lib/idlelib/parenmatch.py
./Lib/idlelib/zzdummy.py
./Lib/idlelib/__main__.py
./Lib/idlelib/history.py
./Lib/idlelib/debugobj_r.py
./Lib/idlelib/replace.py
./Lib/pydoc_data/__init__.py
./Lib/pydoc_data/topics.py
./Lib/ssl.py
./Lib/socket.py
./Lib/datetime.py
./Lib/sysconfig.py
./Lib/collections/__init__.py
./Lib/collections/abc.py
./Lib/pathlib.py
./Lib/_pydecimal.py
./Lib/ntpath.py
./Lib/tokenize.py
./Lib/uuid.py
./Lib/asyncio/queues.py
./Lib/asyncio/streams.py
./Lib/asyncio/tasks.py
./Lib/asyncio/selector_events.py
./Lib/asyncio/log.py
./Lib/asyncio/protocols.py
./Lib/asyncio/events.py
./Lib/asyncio/base_events.py
./Lib/asyncio/subprocess.py
./Lib/asyncio/constants.py
./Lib/asyncio/proactor_events.py
./Lib/asyncio/format_helpers.py
./Lib/asyncio/locks.py
./Lib/asyncio/__init__.py
./Lib/asyncio/trsock.py
./Lib/asyncio/futures.py
./Lib/asyncio/sslproto.py
./Lib/asyncio/staggered.py
./Lib/asyncio/base_subprocess.py
./Lib/asyncio/windows_utils.py
./Lib/asyncio/runners.py
./Lib/asyncio/exceptions.py
./Lib/asyncio/transports.py
./Lib/asyncio/base_tasks.py
./Lib/asyncio/coroutines.py
./Lib/asyncio/windows_events.py
./Lib/asyncio/base_futures.py
./Lib/asyncio/__main__.py
./Lib/asyncio/unix_events.py
./Lib/logging/config.py
./Lib/logging/handlers.py
./Lib/logging/__init__.py
./Lib/imp.py
./Lib/smtpd.py
./Lib/re.py
./Lib/email/contentmanager.py
./Lib/email/_policybase.py
./Lib/email/header.py
./Lib/email/_encoded_words.py
./Lib/email/_header_value_parser.py
./Lib/email/policy.py
./Lib/email/__init__.py
./Lib/email/message.py
./Lib/email/encoders.py
./Lib/email/parser.py
./Lib/email/generator.py
./Lib/email/utils.py
./Lib/email/charset.py
./Lib/email/iterators.py
./Lib/email/quoprimime.py
./Lib/email/mime/multipart.py
./Lib/email/mime/__init__.py
./Lib/email/mime/message.py
./Lib/email/mime/application.py
./Lib/email/mime/nonmultipart.py
./Lib/email/mime/text.py
./Lib/email/mime/audio.py
./Lib/email/mime/image.py
./Lib/email/mime/base.py
./Lib/email/errors.py
./Lib/email/feedparser.py
./Lib/email/_parseaddr.py
./Lib/email/base64mime.py
./Lib/email/headerregistry.py
./Lib/mailcap.py
./Lib/aifc.py
./Lib/struct.py
./Lib/asynchat.py
./Lib/sre_parse.py
./Lib/abc.py
./Lib/runpy.py
./Lib/_bootlocale.py
Copy link
Member

pablogsal left a comment

This looks good to me, thanks @tonybaloney for the PR! 🎉

@pablogsal pablogsal merged commit ef7eaaf into python:master Dec 28, 2019
9 checks passed
9 checks passed
Docs
Details
Windows (x86)
Details
Windows (x64)
Details
macOS
Details
Ubuntu
Details
Azure Pipelines PR #20191227.26 succeeded
Details
bedevere/issue-number Issue number 39144 found
Details
bedevere/news News entry found in Misc/NEWS.d
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@miss-islington

This comment has been minimized.

Copy link

miss-islington commented Dec 28, 2019

Thanks @tonybaloney for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒🤖

@bedevere-bot

This comment has been minimized.

Copy link

bedevere-bot commented Dec 28, 2019

GH-17722 is a backport of this pull request to the 3.8 branch.

@bedevere-bot

This comment has been minimized.

Copy link

bedevere-bot commented Dec 28, 2019

GH-17723 is a backport of this pull request to the 3.7 branch.

miss-islington added a commit to miss-islington/cpython that referenced this pull request Dec 28, 2019
…e Python stdlib files (pythonGH-17721)

(cherry picked from commit ef7eaaf)

Co-authored-by: Anthony Shaw <anthony.p.shaw@gmail.com>
miss-islington added a commit that referenced this pull request Dec 28, 2019
…e Python stdlib files (GH-17721)

(cherry picked from commit ef7eaaf)

Co-authored-by: Anthony Shaw <anthony.p.shaw@gmail.com>
miss-islington added a commit that referenced this pull request Dec 28, 2019
…e Python stdlib files (GH-17721)

(cherry picked from commit ef7eaaf)

Co-authored-by: Anthony Shaw <anthony.p.shaw@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.