Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos and remove deprecated deprecation warning in library/ctypes doc. #17741

Merged
merged 1 commit into from Dec 29, 2019

Conversation

@awecx
Copy link
Contributor

awecx commented Dec 29, 2019

Summary of the proposed changes made:

l.164: this warning should be removed as the exception is not raised anymore since 3.7 ;
l.627: grammar typo ;
l.925: grammar typo ;
l.1129: size should be highlighted as we are referring to the actual member name from the snippet.

No issue has been linked to this PR.

@pablogsal

This comment has been minimized.

Copy link
Member

pablogsal commented Dec 29, 2019

Thanks for the PR @awecx !

@pablogsal pablogsal merged commit 32a12ae into python:master Dec 29, 2019
5 checks passed
5 checks passed
Docs
Details
Azure Pipelines PR #20191229.31 succeeded
Details
bedevere/issue-number Issue report skipped
bedevere/news "skip news" label found
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@miss-islington

This comment has been minimized.

Copy link

miss-islington commented Dec 29, 2019

Thanks @awecx for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒🤖

@bedevere-bot

This comment has been minimized.

Copy link

bedevere-bot commented Dec 29, 2019

GH-17743 is a backport of this pull request to the 3.8 branch.

@bedevere-bot

This comment has been minimized.

Copy link

bedevere-bot commented Dec 29, 2019

GH-17744 is a backport of this pull request to the 3.7 branch.

miss-islington added a commit to miss-islington/cpython that referenced this pull request Dec 29, 2019
(cherry picked from commit 32a12ae)

Co-authored-by: Antoine <43954001+awecx@users.noreply.github.com>
miss-islington added a commit that referenced this pull request Dec 29, 2019
(cherry picked from commit 32a12ae)

Co-authored-by: Antoine <43954001+awecx@users.noreply.github.com>
miss-islington added a commit that referenced this pull request Dec 29, 2019
(cherry picked from commit 32a12ae)

Co-authored-by: Antoine <43954001+awecx@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.