Skip to content

Fix typos in concurrent.Futures documentation #10920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 5, 2018
Merged

Fix typos in concurrent.Futures documentation #10920

merged 1 commit into from
Dec 5, 2018

Conversation

funkyHat
Copy link
Contributor

@funkyHat funkyHat commented Dec 5, 2018 •
edited by Mariatta
Loading

Add a missing word as in as well as an.
Linkify threading.Thread.

@funkyHat
a couple of small fixes to concurrent.futures.rst
fd4273b 
1 typo, 1 missing class reference
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Dec 5, 2018
@funkyHat
Copy link
Contributor Author

funkyHat commented Dec 5, 2018

(CLA now signed, & I think a bug & news entry would probably be overkill :)

@Mariatta Mariatta changed the title a couple of small fixes to concurrent.futures.rst Fix typos in concurrent.Futures documentation Dec 5, 2018
@miss-islington miss-islington merged commit 40a61da into python:master Dec 5, 2018
@miss-islington
Copy link
Contributor

Thanks @funkyHat for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-10957 is a backport of this pull request to the 3.7 branch.

@miss-islington
Copy link
Contributor

Sorry, @funkyHat, I could not cleanly backport this to 3.6 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 40a61da40d252626f8b9ff524d76c1f0ccb3a4f7 3.6

@miss-islington miss-islington self-assigned this Dec 5, 2018
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 5, 2018
@funkyHat @miss-islington
Fix typos in concurrent.Futures documentation (pythonGH-10920)
124c207 
Add a missing word `as` in `as well as an`.
Linkify `threading.Thread`.
(cherry picked from commit 40a61da)

Co-authored-by: Matt Wheeler <m@funkyhat.org>
@bedevere-bot
Copy link

GH-10958 is a backport of this pull request to the 3.6 branch.

Mariatta pushed a commit to Mariatta/cpython that referenced this pull request Dec 5, 2018
@funkyHat @Mariatta
[3.6] Fix typos in concurrent.Futures documentation (pythonGH-10920)
0af194a 
Add a missing word `as` in `as well as an`.
Linkify `threading.Thread`..
(cherry picked from commit 40a61da)

Co-authored-by: Matt Wheeler <m@funkyhat.org>
@Mariatta
Copy link
Member

Mariatta commented Dec 5, 2018

Thanks @funkyHat and congrats on your first contribution to CPython 🌮

miss-islington added a commit that referenced this pull request Dec 5, 2018
@miss-islington @funkyHat
Fix typos in concurrent.Futures documentation (GH-10920)
022d7bc 
Add a missing word `as` in `as well as an`.
Linkify `threading.Thread`.
(cherry picked from commit 40a61da)

Co-authored-by: Matt Wheeler <m@funkyhat.org>
miss-islington pushed a commit that referenced this pull request Dec 5, 2018
@Mariatta @funkyHat @miss-islington
[3.6] Fix typos in concurrent.Futures documentation (GH-10920) (GH-10958
2997fa4 
)

Add a missing word `as` in `as well as an`.
Linkify `threading.Thread`..
(cherry picked from commit 40a61da)

Co-authored-by: Matt Wheeler <m@funkyhat.org>
@funkyHat funkyHat deleted the patch-1 branch December 6, 2018 09:46
@csabella csabella mentioned this pull request May 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mariatta Mariatta Mariatta approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@funkyHat @the-knights-who-say-ni @miss-islington @bedevere-bot @Mariatta