bpo-35450: reflect in docs that venv module is not always creating a … #11144
Conversation
…copy of python binary
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. You can check yourself to see if the CLA has been received. Thanks again for your contribution, we look forward to reviewing it! |
|
I have integrated bugs.python.org with my github account. |
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
@mkkot only one minor grammatical change to make. Otherwise I'm just waiting for your CLA to be processed and then I can merge the change! |
|
@mkkot CLA has been signed! So if you can either accept the grammar fix (or give maintainers commit rights on your branch) and then we can merge this! |
|
Sure, please merge. What about backporting, who is dealing with this? |
|
@mkkot our magical bots handle backports 😄 (that's what the labels actually trigger). |
|
@mkkot I can't merge until you either accept the suggested fix or click the checkbox to let maintainers modify your branch (I just tried and GitHub says I can't do it). |
|
@brettcannon I resolved the conversation, hope now you can merge. |
|
@mkkot: Status check is done, and it's a success ✅ . |
|
Thanks @mkkot for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7. |
|
GH-11167 is a backport of this pull request to the 3.7 branch. |
pythonGH-11144) …copy of python binary https://bugs.python.org/issue35450 (cherry picked from commit f5107df) Co-authored-by: mkkot <marcin2006@gmail.com>
|
GH-11168 is a backport of this pull request to the 3.6 branch. |
pythonGH-11144) …copy of python binary https://bugs.python.org/issue35450 (cherry picked from commit f5107df) Co-authored-by: mkkot <marcin2006@gmail.com>
|
@mkkot I actually wanted the suggested change to get merged, but it turned out I had the appropriate permissions to edit the file, so I just went ahead and did that. Thanks for the PR! |
…copy of the Python binary (GH-11144) (GH-11167) https://bugs.python.org/issue35450 (cherry picked from commit f5107df) Co-authored-by: mkkot <marcin2006@gmail.com>
…copy of python binary
https://bugs.python.org/issue35450