Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign up[3.6] bpo-36564: Fix infinite loop in email folding logic (GH-12732) #14799
+35
−6
Conversation
As far as I can tell, this infinite loop would be triggered if: 1. The value being folded contains a single word (no spaces) longer than max_line_length 2. The max_line_length is shorter than the encoding's name + 9 characters. bpo-36564: https://bugs.python.org/issue36564 (cherry picked from commit f69d5c6) Co-authored-by: Paul Ganssle <pganssle@users.noreply.github.com>
warsaw
changed the title
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
The failure is due to:
The Linux builds on Azure and Travis went through without any errors. Maybe we need to restart the build on Appveyor. |
This comment has been minimized.
This comment has been minimized.
|
Thanks for looking into it. I wouldn’t worry about the failure. I will take a look and presumably merge the PR later when I’m back from holiday. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Sorry, I can't merge this PR. Reason: |
ned-deily
merged commit 79a47e2
into
python:3.6
6 checks passed
6 checks passed
bedevere/maintenance-branch-pr
Valid maintenance branch PR title.
bedevere/news
News entry found in Misc/NEWS.d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
miss-islington commentedJul 16, 2019
•
edited by bedevere-bot
As far as I can tell, this infinite loop would be triggered if:
max_line_length
characters.
bpo-36564: https://bugs.python.org/issue36564
(cherry picked from commit f69d5c6)
Co-authored-by: Paul Ganssle pganssle@users.noreply.github.com
https://bugs.python.org/issue36564