Skip to content

/cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added link to zlib v1.1.3 vulnerability #17156

Merged
merged 1 commit into from Jan 3, 2020
Merged

Added link to zlib v1.1.3 vulnerability #17156

merged 1 commit into from Jan 3, 2020
+2 −3

Conversation

@nosahama
Copy link
Contributor

nosahama commented Nov 14, 2019

This change adds a link to the vulnerability of the zlib v1.1.3 library (double-free vulnerability). In my own opinion, i feel some curious people might find it handy.
@the-knights-who-say-ni

This comment has been minimized.

Sign in to view
Copy link

the-knights-who-say-ni commented Nov 14, 2019

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@nosahama

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!
@brandtbucher

This comment has been minimized.

Sign in to view
Copy link
Member

brandtbucher commented Nov 14, 2019 •
edited

Thanks for your time @nosahama, and welcome to CPython!

I assume that you've seen the bot's message about the CLA?
@brandtbucher
brandtbucher suggested changes Nov 14, 2019
View changes
Copy link
Member

brandtbucher left a comment

I agree that this is helpful. One minor comment:
Doc/library/zlib.rst Outdated Show resolved Hide resolved
@nosahama

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

nosahama commented Nov 14, 2019

Thanks for your time @nosahama, and welcome to CPython!

I assume that you've seen the bot's message about the CLA?

I did that already, i don't know what it's not showing up, maybe eventual consistency 😅
@brandtbucher

This comment has been minimized.

Sign in to view
Copy link
Member

brandtbucher commented Nov 14, 2019

Yeah, give it a business day or two. As I understand it, they're processed manually by a human at the PSF.
@nosahama
Added link to zlib v1.1.3 vulnerability
Loading status checks…
dfacdb6 
This change adds a link to the vulnerability of the `zlib v1.1.3` library (double-free vulnerability). In my own opinion, i feel some curious people might find it handy.
@nosahama nosahama force-pushed the nosahama:patch-1 branch from 5d9f15b to dfacdb6 Nov 14, 2019
@brandtbucher

This comment has been minimized.

Sign in to view
Copy link
Member

brandtbucher commented Nov 14, 2019

CC @Yhg1s
@brandtbucher
brandtbucher approved these changes Nov 14, 2019
View changes
Copy link
Member

brandtbucher left a comment

Looks good!
@Yhg1s Yhg1s merged commit b789202 into python:master Jan 3, 2020
4 checks passed
4 checks passed
Azure Pipelines PR #20191114.40 succeeded
Details
bedevere/issue-number Issue report skipped
bedevere/news "skip news" label found
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandtbucher brandtbucher

Assignees
No one assigned
Labels
CLA signed skip issue skip news type-documentation
Projects
None yet
Milestone
No milestone
5 participants
@nosahama @the-knights-who-say-ni @brandtbucher @Yhg1s @bedevere-bot
You can’t perform that action at this time.