Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upbpo-15795: Preserve permissions on UNIX (based/like) systems #17790
Conversation
The reasoning behind this is that the unzip command (Info-ZIP) on pretty much every unix system will preserve the permissions by default. The Info-ZIP unzip command is shipped with all currently supported versions of: - MacOS - OpenBSD and NetBSD - Probably every manjor Linux distribution Here is a list: https://pkgs.org/download/unzip
This comment has been minimized.
This comment has been minimized.
the-knights-who-say-ni
commented
Jan 1, 2020
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). Recognized GitHub usernameWe couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames: This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
sharkwouter commentedJan 1, 2020
•
edited
The reasoning behind this is that the unzip command (Info-ZIP) on pretty much every unix system will preserve the permissions by default.
The Info-ZIP unzip command is shipped with all currently supported versions of:
Here is a list: https://pkgs.org/download/unzip
In this pull request the permissions are only preserved if a zip file is extracted on a posix system and the zipfile was made on a UNIX system. Permissions are also set for directories.
https://bugs.python.org/issue15795