Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upbpo-39199: Uses the io.DEFAULT_BUFFER_SIZE variable instead of defining it again #17736
Conversation
This comment has been minimized.
This comment has been minimized.
the-knights-who-say-ni
commented
Dec 29, 2019
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). Recognized GitHub usernameWe couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames: This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
This comment has been minimized.
This comment has been minimized.
|
@GreatBahram, thank you for the contribution! Please open a ticket on bugs.python.org for this issue. Even though it's a small change, having a ticket on the bug tracker gives higher visibility to items and a better chance for it to be reviewed. Also, please signed the CLA as requested by the bot. Thanks! |
This comment has been minimized.
This comment has been minimized.
|
Hi, Thanks for the explanation, I signed as it was explained and also opened an issue for this purpose: https://bugs.python.org/issue39189 Is there anything else? |
This comment has been minimized.
This comment has been minimized.
|
@GreatBahram can you alter the title with |
GreatBahram
changed the title
GreatBahram
changed the title
GreatBahram
changed the title
This comment has been minimized.
This comment has been minimized.
|
@bedevere-bot accidentally edited my original message, ignore that and check the original one from edit history. |
GreatBahram
changed the title
This comment has been minimized.
This comment has been minimized.
|
Anything else? |
GreatBahram commentedDec 29, 2019
Hello there,
This Pull Request replaces the BUFSIZE variable with the existing one inside the
iomodule.Explanation:
I just removed the BUFSIZE global variable and replaced it with the io.DEFAULT_BUFFER_SIZE variable.
I couldn't find an open issue for this, but I do believe it does not need one, as it is a trivial issue!
I checked other branches, this problem affects below branches as well.