Skip to content

/cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify control flow when exiting the interpreter. #17756

Open
wants to merge 1 commit into
base: master
from
Open

Simplify control flow when exiting the interpreter. #17756

wants to merge 1 commit into from
+5 −42

Conversation

@markshannon
Copy link
Contributor

markshannon commented Dec 30, 2019

Skip the stack emptying step for RETURN_VALUE, as the compiler now ensures that the stack is empty.

Remove test that generates invalid bytecode.
Maybe we should have a bytecode verifier, but that's not the job of the interpreter.

No change in behaviour, so no news or BPO issue needed.
@markshannon
Cleanup exit code for interpreter.
Loading status checks…
fa9c5d3
@pablogsal
pablogsal approved these changes Dec 30, 2019
View changes
@pablogsal

This comment has been minimized.

Sign in to view
Copy link
Member

pablogsal commented Dec 30, 2019

as the compiler now ensures that the stack is empty

Out of curiosity, in which PR/issue was this changed?
@markshannon

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

markshannon commented Dec 30, 2019

#6641
@pablogsal

This comment has been minimized.

Sign in to view
Copy link
Member

pablogsal commented Dec 30, 2019

#6641

Thanks, Mark!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablogsal pablogsal

Assignees
No one assigned
Labels
CLA signed awaiting merge skip issue skip news
Projects
None yet
Milestone
No milestone
4 participants
@markshannon @pablogsal @the-knights-who-say-ni @bedevere-bot
You can’t perform that action at this time.