[2.7] bpo-27973 - urlretrive fails on second ftp transfer. #17774

orsenthil · 2019-12-31T21:34:01Z

Fix the permission denied errors on Windows.

This is a fix for the permission denied error observed on windows buildbots.

Tests result: FAILURE then FAILURE
test test_urllibnet failed -- Traceback (most recent call last):
  File "D:\cygwin\home\db3l\buildarea\2.7.bolen-windows7\build\lib\test\test_urllibnet.py", line 232, in test_multiple_ftp_retrieves
    "multiple times.\n Error message was : %s" % e)
AssertionError: Failed FTP retrieve while accessing ftp url multiple times.
 Error message was : [Errno 13] Permission denied: 'd:\\temp\\tmpiuquqa'
Example failure:

https://buildbot.python.org/all/#/builders/209/builds/4

https://bugs.python.org/issue27973


        bpo-27973 - Use test.support.temp_dir instead of NamedTemporaryFile f…

…or the desired behavior under windows platform. Suggestion by David Bolen

orsenthil · 2020-01-03T21:41:49Z

@benjaminp please review this. This will fix 2.7 windows build bots.

bedevere-bot · 2020-01-04T02:14:22Z

@orsenthil: Please replace # with GH- in the commit message next time. Thanks!


        Revert "bpo-27973 - Use test.support.temp_dir instead of NamedTempora…

…ryFile for the (#17774)" This reverts commit 5bba602.

orsenthil · 2020-01-04T02:28:23Z

I am not sure why we are seeing these buildbot failures on 2.7 branch.
All of the failures observed during build step of 2.7

pablogsal · 2020-01-04T02:33:04Z

@orsenthil Please, Ignore this failure - I was trying to fix something on the server at the same time :(

Apologies for the noise 😢

orsenthil · 2020-01-04T02:35:06Z

I am not sure why we are seeing these buildbot failures on 2.7 branch.

I see this was failing even for the previous SHA. Just the notifications are new.

orsenthil · 2020-01-04T02:35:54Z

Thanks, @pablogsal

pablogsal · 2020-01-04T02:38:45Z

I have re-triggered a build of all the 2.7 buildbots that failed (with the correct build steps) si they should be green in some minutes. Apologies again for the noise.

pablogsal · 2020-01-04T02:42:19Z

@orsenthil By the way, I will announce this soon (still secret 😉 ) but now you can use the "🔨 test-with-buildbots" label to require all buildbots to report to the PR before merging! 🎉

orsenthil · 2020-01-04T02:46:43Z

I will announce this soon (still secret wink ) but now you can use the "hammer test-with-buildbots" label to require all buildbots to report to the PR before merging!

this will be super cool !

Thank you very much for this feature. :-)

the-knights-who-say-ni added the CLA signed label Dec 31, 2019

bedevere-bot added type-tests awaiting core review labels Dec 31, 2019

orsenthil added the skip news label Dec 31, 2019

orsenthil changed the title ~~bpo-27973 - urlretrive fails on second ftp transfer.~~ [2.7] bpo-27973 - urlretrive fails on second ftp transfer. Dec 31, 2019

aeros added the OS-windows label Jan 1, 2020

bpo-27973 - Use test.support.temp_dir instead of NamedTemporaryFile f…

Loading status checks…

ae8b457

…or the desired behavior under windows platform. Suggestion by David Bolen

orsenthil force-pushed the orsenthil:issue27973-win-fix branch from 78a18e8 to ae8b457 Jan 3, 2020

benjaminp approved these changes Jan 4, 2020

View changes

bedevere-bot added awaiting merge and removed awaiting core review labels Jan 4, 2020

orsenthil deleted the orsenthil:issue27973-win-fix branch Jan 4, 2020

bedevere-bot removed the awaiting merge label Jan 4, 2020

orsenthil added a commit that referenced this pull request Jan 4, 2020

Revert "bpo-27973 - Use test.support.temp_dir instead of NamedTempora…

Loading status checks…

2ddf725

…ryFile for the (#17774)" This reverts commit 5bba602.

orsenthil mentioned this pull request Jan 4, 2020

[2.7] Revert bpo-27973 - urlretrive fails on second ftp transfer." #17819

Closed

python deleted a comment from bedevere-bot Jan 4, 2020

python/cpython

[2.7] bpo-27973 - urlretrive fails on second ftp transfer. #17774

[2.7] bpo-27973 - urlretrive fails on second ftp transfer. #17774

orsenthil commented Dec 31, 2019 •

edited by bedevere-bot

This comment has been minimized.

orsenthil commented Jan 3, 2020

This comment has been minimized.

bedevere-bot commented Jan 4, 2020

This comment has been minimized.

orsenthil commented Jan 4, 2020

This comment has been minimized.

pablogsal commented Jan 4, 2020 •

edited

This comment has been minimized.

orsenthil commented Jan 4, 2020

This comment has been minimized.

orsenthil commented Jan 4, 2020

This comment has been minimized.

pablogsal commented Jan 4, 2020 •

edited

This comment has been minimized.

pablogsal commented Jan 4, 2020

This comment has been minimized.

orsenthil commented Jan 4, 2020

Sponsor python/cpython

python/cpython

Join GitHub today

[2.7] bpo-27973 - urlretrive fails on second ftp transfer. #17774

[2.7] bpo-27973 - urlretrive fails on second ftp transfer. #17774

Conversation

orsenthil commented Dec 31, 2019 • edited by bedevere-bot

This comment has been minimized.

orsenthil commented Jan 3, 2020

This comment has been minimized.

bedevere-bot commented Jan 4, 2020

This comment has been minimized.

orsenthil commented Jan 4, 2020

This comment has been minimized.

pablogsal commented Jan 4, 2020 • edited

This comment has been minimized.

orsenthil commented Jan 4, 2020

This comment has been minimized.

orsenthil commented Jan 4, 2020

This comment has been minimized.

pablogsal commented Jan 4, 2020 • edited

This comment has been minimized.

pablogsal commented Jan 4, 2020

This comment has been minimized.

orsenthil commented Jan 4, 2020

orsenthil commented Dec 31, 2019 •

edited by bedevere-bot

pablogsal commented Jan 4, 2020 •

edited

pablogsal commented Jan 4, 2020 •

edited