[2.7] ceval.c: mark debug 'filename' variable as unused #11074
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use GCC __attribute__((unused)) to mark the debug variable 'filename' as unused in Python/ceval.c.
vstinner
changed the title
|
If it is unused, why not just remove it? |
See the comment: It's an helper to be able to read directly the current filename easy in a debugger. Without this variable, you have to inspect co->co_filename PyStringObject object to get its ob_sval attribute. I think that this variable is useful. It's only defined with Python is compiled in debug mode. |
serhiy-storchaka
approved these changes
Dec 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use GCC attribute((unused)) to mark the debug variable 'filename'
as unused in Python/ceval.c.