Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-34410: Fix a crash in the tee iterator when re-enter it. #15625

Merged
merged 2 commits into from Sep 9, 2019

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Aug 30, 2019

RuntimeError is now raised in this case.

https://bugs.python.org/issue34410

@serhiy-storchaka serhiy-storchaka added the type-bug label Aug 30, 2019
@serhiy-storchaka serhiy-storchaka changed the title bpo-34410: Fix a crash in the tee iterator when re-enter it. [3.8] bpo-34410: Fix a crash in the tee iterator when re-enter it. Aug 30, 2019
@serhiy-storchaka serhiy-storchaka removed the request for review from ezio-melotti Sep 9, 2019
@python python deleted a comment from the-knights-who-say-ni Sep 9, 2019
@serhiy-storchaka serhiy-storchaka merged commit 526a014 into python:master Sep 9, 2019
5 of 6 checks passed
@serhiy-storchaka serhiy-storchaka deleted the tee-reenter-3.8 branch Sep 9, 2019
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Sep 9, 2019

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.7, 3.8.
🐍🍒🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this issue Sep 9, 2019
…H-15625)

RuntimeError is now raised in this case.
(cherry picked from commit 526a014)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Sep 9, 2019

GH-15737 is a backport of this pull request to the 3.8 branch.

@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Sep 9, 2019

GH-15738 is a backport of this pull request to the 3.7 branch.

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Sep 9, 2019

Sorry, @serhiy-storchaka, I could not cleanly backport this to 2.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 526a01467b3277f9fcf7f91e66c23321caa1245d 2.7

miss-islington pushed a commit to miss-islington/cpython that referenced this issue Sep 9, 2019
…H-15625)

RuntimeError is now raised in this case.
(cherry picked from commit 526a014)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this issue Sep 9, 2019
…ythonGH-15625)

RuntimeError is now raised in this case..
(cherry picked from commit 526a014)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Sep 9, 2019

GH-15740 is a backport of this pull request to the 2.7 branch.

miss-islington added a commit that referenced this issue Sep 9, 2019
RuntimeError is now raised in this case.
(cherry picked from commit 526a014)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
miss-islington added a commit that referenced this issue Sep 9, 2019
RuntimeError is now raised in this case.
(cherry picked from commit 526a014)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka added a commit that referenced this issue Sep 9, 2019
…H-15625) (GH-15740)

RuntimeError is now raised in this case.
(cherry picked from commit 526a014)
lisroach pushed a commit to lisroach/cpython that referenced this issue Sep 10, 2019
vrpolakatcisco pushed a commit to vrpolakatcisco/cpython that referenced this issue Sep 12, 2019
DinoV pushed a commit to DinoV/cpython that referenced this issue Jan 14, 2020
websurfer5 pushed a commit to websurfer5/cpython that referenced this issue Jul 20, 2020
@serhiy-storchaka serhiy-storchaka removed their assignment Dec 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA signed type-bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants