bpo-34282: Fix Enum._convert shadowing members named _convert #8568
Conversation
|
Is a news entry needed? |
orlnub123
changed the title
|
I've gone ahead and added a news entry. |
Lib/enum.py
Outdated
| @@ -424,6 +424,39 @@ def _create_(cls, class_name, names, *, module=None, qualname=None, type=None, s | |||
|
|
|||
| return enum_class | |||
|
|
|||
| def _convert(cls, name, module, filter, source=None): | |||
There was a problem hiding this comment.
See notes in bpo issue. Thanks for your help in this!
There was a problem hiding this comment.
Glad to help! I've got some questions about them in the issue.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
I have made the requested changes; please review again. |
|
Thanks for making the requested changes! @ethanfurman: please review the changes made to this pull request. |
|
I've merged the changes from #9034. |
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
Thanks for the offer, I really appreciate it. I hope I've added myself to the right place! I have made the requested changes; please review again. |
|
Thanks for making the requested changes! @ethanfurman: please review the changes made to this pull request. |
I've combined the third solution with the second from the issue below, circumventing its problem.
https://bugs.python.org/issue34282