Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upMinor doc fixes in urllib.parse #17745
Merged
+27
−26
Conversation
This comment has been minimized.
This comment has been minimized.
|
@verhovsky, thank you for your contribution. I agree with your suggested changes. For the future, this many changes probably could have had a ticket on the bug tracker. Having a ticket raises the visibility of issues, so you have a better chance of a core dev seeing the PR. |
|
LGTM |
This comment has been minimized.
This comment has been minimized.
miss-islington
commented
Dec 31, 2019
|
Thanks @verhovsky for the PR |
This comment has been minimized.
This comment has been minimized.
miss-islington
commented
Dec 31, 2019
|
Sorry, @verhovsky, I could not cleanly backport this to |
sthagen
added a commit
to sthagen/cpython
that referenced
this pull request
Dec 31, 2019
Minor doc fixes in urllib.parse (pythonGH-17745)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
verhovsky commentedDec 30, 2019
•
edited by miss-islington
Automerge-Triggered-By: @csabella