New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-39206: Add encoding detecting to modulefinder #17817

Open

LucianaMarques wants to merge 1 commit into python:master from LucianaMarques:fix-issue-39206

+7 −1

LucianaMarques commented Jan 4, 2020 •

edited by bedevere-bot

Fixing issue 39206.

https://bugs.python.org/issue39206

the-knights-who-say-ni added the CLA not signed label

the-knights-who-say-ni commented Jan 4, 2020

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@LucianaMarques

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

bedevere-bot added the awaiting review label

Author

LucianaMarques commented Jan 4, 2020

Just recording, I just signed the CLA.


        Add encoding detecting to modulefinder

8251bd0

LucianaMarques force-pushed the LucianaMarques:fix-issue-39206 branch from a47ad67 to 8251bd0

LucianaMarques mentioned this pull request

Add CLA note to top of quick-reference #559

Open

asottile reviewed

Lib/modulefinder.py

  
                with open(file_path, 'rb') as file:

                    encoding = tokenize.detect_encoding(file.readline)[0]

            file = open(file_path, mode, encoding=encoding)

asottile Jan 5, 2020

Contributor

maybe slightly simpler?

if mode == 'r':
    file = tokenize.open(file_path)
else:
    file = open(file_path, mode)

LucianaMarques Jan 5, 2020

Author

Sure, I'll update it later today. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

You can’t perform that action at this time.