Skip to content

/cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-39156: Break up COMPARE_OP into four logically distinct opcodes. #17754

Open
wants to merge 1 commit into
base: master
from
Open

bpo-39156: Break up COMPARE_OP into four logically distinct opcodes. #17754

wants to merge 1 commit into from
+4,882 −4,830

Conversation

@markshannon
Copy link
Contributor

markshannon commented Dec 30, 2019 •
edited by bedevere-bot

Breaks up COMPARE_OP into four logically distinct opcodes:

  • COMPARE_OP for rich comparisons
  • IS_OP for 'is' and 'is not' tests
  • CONTAINS_OP for 'in' and 'is not' tests
  • JUMP_IF_NOT_EXC_MATCH for checking exceptions in 'try-except' statements.

This improves the clarity of the interpreter and should provide a modest speedup.

https://bugs.python.org/issue39156
@markshannon markshannon force-pushed the markshannon:breakup-compare-op branch 2 times, most recently from 0912805 to 3f4e3d4 Dec 30, 2019
@markshannon
Break up COMPARE_OP into four logically distinct opcodes:
Loading status checks…
2ee4c16 
   COMPARE_OP for rich comparisons
   IS_OP for 'is' and 'is not' tests
   CONTAINS_OP for 'in' and 'is not' tests
   JUMP_IF_NOT_EXC_MATCH for checking exceptions in 'try-except' statements.
@markshannon markshannon force-pushed the markshannon:breakup-compare-op branch from 3f4e3d4 to 2ee4c16 Dec 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA signed awaiting core review
Projects
None yet
Milestone
No milestone
3 participants
@markshannon @the-knights-who-say-ni @bedevere-bot
You can’t perform that action at this time.