Skip to content

/cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-39191: Don't spawn a task before failing with already running loop #17796

Merged
merged 1 commit into from Jan 4, 2020
Merged

bpo-39191: Don't spawn a task before failing with already running loop #17796

merged 1 commit into from Jan 4, 2020
+10 −3

Conversation

@asvetlov
Copy link
Contributor

asvetlov commented Jan 2, 2020 •
edited by bedevere-bot

https://bugs.python.org/issue39191
@asvetlov
Fix #39191: Don't spawn a task before failing
Loading status checks…
ebba902
@asvetlov asvetlov requested a review from 1st1 as a code owner Jan 2, 2020
@Kaveshnikov
Kaveshnikov approved these changes Jan 3, 2020
View changes
@asvetlov asvetlov merged commit 3a5de51 into python:master Jan 4, 2020
9 checks passed
9 checks passed
Docs
Details
Windows (x86)
Details
Windows (x64)
Details
macOS
Details
Ubuntu
Details
Azure Pipelines PR #20200102.12 succeeded
Details
bedevere/issue-number Issue number 39191 found
Details
bedevere/news News entry found in Misc/NEWS.d
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@asvetlov asvetlov deleted the asvetlov:fix-run_until_complete branch Jan 4, 2020
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Jan 4, 2020

@asvetlov: Please replace # with GH- in the commit message next time. Thanks!
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Jan 4, 2020

Thanks @asvetlov for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Jan 4, 2020

Sorry, @asvetlov, I could not cleanly backport this to 3.8 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 3a5de511596f17575de082dcb8d43d63b2bd2da9 3.8
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Jan 4, 2020

Sorry @asvetlov, I had trouble checking out the 3.7 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 3a5de511596f17575de082dcb8d43d63b2bd2da9 3.7
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Jan 4, 2020

GH-17820 is a backport of this pull request to the 3.8 branch.
asvetlov added a commit to asvetlov/cpython that referenced this pull request Jan 4, 2020
@asvetlov
[3.8] Fix GH-39191: Don't spawn a task before failing (pythonGH-17796).
32ac1a1 
(cherry picked from commit 3a5de51)

Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com>
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Jan 4, 2020

GH-17821 is a backport of this pull request to the 3.7 branch.
asvetlov added a commit that referenced this pull request Jan 4, 2020
@asvetlov
[3.8] bpo-39191: Don't spawn a task before failing (GH-17796) (GH-17820)
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
867d833 
(cherry picked from commit 3a5de51)

Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com>
asvetlov added a commit that referenced this pull request Jan 4, 2020
@asvetlov
[3.7] bpo-39191: Don't spawn a task before failing (GH-17796) (#17821)
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
9c145e1 
(cherry picked from commit 3a5de51)

Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kaveshnikov Kaveshnikov

@1st1 1st1

Assignees

@asvetlov asvetlov

Labels
CLA signed
Projects
None yet
Milestone
No milestone
5 participants
@asvetlov @bedevere-bot @miss-islington @Kaveshnikov @the-knights-who-say-ni
You can’t perform that action at this time.