Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upbpo-35292: Avoid call mimetypes.init when http.server is imported #17822
+10
−13
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
aisk commentedJan 4, 2020
•
edited
Proxy the
http.server.SimpleHTTPRequestHandler.guess_typetomimetypes.guess_typeso themimetypes.initis called lazily to avoid unnecessary costs when the file is imported.The default
extensions_mapis checked before callmimetypes.guess_type, with default value inmimetypes.encodings_map, for don't letmimetypes.guess_typereturns the mine type besides the encoding type.This method is implemented as https://bugs.python.org/issue35292#msg331739 said @zooba
https://bugs.python.org/issue35292