Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-29778: Fix incorrect NULL check #17818

Open
wants to merge 1 commit into
base: master
from

Conversation

@anthonywee
Copy link

anthonywee commented Jan 4, 2020

The commit below introduced a NULL check which causes a call to _PyPathConfig_InitDLLPath()
to be skipped if _Py_dll_path == NULL.

c422167#diff-87aed37b4704d4e1513be6378c9c7fe6R169

https://bugs.python.org/issue29778

The commit below introduced a NULL check which causes a call to _PyPathConfig_InitDLLPath()
to be skipped if _Py_dll_path == NULL.

c422167#diff-87aed37b4704d4e1513be6378c9c7fe6R169
@the-knights-who-say-ni

This comment has been minimized.

Copy link

the-knights-who-say-ni commented Jan 4, 2020

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@anthonywee

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

Copy link
Member

corona10 left a comment

@anthonywee Thanks for the contribution to CPython project.
Please sign up the CLA, please :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.