Skip to content

/ cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Py_DECREF: only pass filename if Py_REF_DEBUG is defined #17870

Open
wants to merge 2 commits into
base: master
from
Open

Py_DECREF: only pass filename if Py_REF_DEBUG is defined #17870

wants to merge 2 commits into from
+10 −5

Conversation

@vstinner
Copy link
Member

vstinner commented Jan 6, 2020

Filename and line numbers are not needed when Py_REF_DEBUG are not
defined.

The static inline _Py_DECREF() function was introduced by
commit 2aaf0c1.
@vstinner
Py_DECREF: only pass filename if Py_REF_DEBUG is defined
Loading status checks…
f860778 
Filename and line numbers are not needed when Py_REF_DEBUG are not
defined.

The static inline _Py_DECREF() function was introduced by
commit 2aaf0c1.
@vstinner vstinner mentioned this pull request Jan 6, 2020
Open
@vstinner

This comment has been minimized.

Sign in to view
Copy link
Member Author

vstinner commented Jan 6, 2020

See PR #16781 for my first attempt.
@vstinner

This comment has been minimized.

Sign in to view
Copy link
Member Author

vstinner commented Jan 6, 2020

@Yhg1s @serhiy-storchaka: Does this version look better than PR #16781?
@vstinner
Fix compilation in release mode
Loading status checks…
bada3b9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA signed awaiting core review skip issue skip news
Projects
None yet
Milestone
No milestone
3 participants
@vstinner @the-knights-who-say-ni @bedevere-bot
You can’t perform that action at this time.