bpo-35292: Avoid call mimetypes.init when http.server is imported #17822

aisk · 2020-01-04T16:39:27Z

Proxy the http.server.SimpleHTTPRequestHandler.guess_type to mimetypes.guess_type so the mimetypes.init is called lazily to avoid unnecessary costs when the file is imported.

The default extensions_map is checked before call mimetypes.guess_type, with default value in mimetypes.encodings_map, for don't let mimetypes.guess_type returns the mine type besides the encoding type.

This method is implemented as https://bugs.python.org/issue35292#msg331739 said @zooba

https://bugs.python.org/issue35292


        bpo-35292: Avoid call mimetypes.init when http.server is imported

zooba · 2020-01-06T16:53:35Z

SimpleHTTPRequestHandler.extensions_map is documented (presumably in Doc/library/http.server.rst), so let's also add a note there clarifying that it "contains custom overrides for the default system mappings". Also add a `.. versionchanged: 3.9 This dictionary is no longer filled with the default system mappings, but only contains overrides." (properly formatted)

I think this deserves a NEWS entry - the failed check's Details link will help you add it.

bpo-35292: Avoid call mimetypes.init when http.server is imported

Loading status checks…

b766ac0

the-knights-who-say-ni added the CLA signed label Jan 4, 2020

bedevere-bot added the awaiting review label Jan 4, 2020

python / cpython

bpo-35292: Avoid call mimetypes.init when http.server is imported #17822

bpo-35292: Avoid call mimetypes.init when http.server is imported #17822

aisk commented Jan 4, 2020 •

edited

This comment has been minimized.

zooba commented Jan 6, 2020

python / cpython

Sponsor python/cpython

Perfect your code

bpo-35292: Avoid call mimetypes.init when http.server is imported #17822

bpo-35292: Avoid call mimetypes.init when http.server is imported #17822

Conversation

aisk commented Jan 4, 2020 • edited

This comment has been minimized.

zooba commented Jan 6, 2020

aisk commented Jan 4, 2020 •

edited