Skip to content

/cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-39239: epoll.unregister() no longer ignores EBADF #17882

Open
wants to merge 1 commit into
base: master
from
Open

bpo-39239: epoll.unregister() no longer ignores EBADF #17882

wants to merge 1 commit into from
+13 −6

Conversation

@vstinner
Copy link
Member

vstinner commented Jan 6, 2020 •
edited by bedevere-bot

The select.epoll.unregister() method no longer ignores the EBADF
error.

https://bugs.python.org/issue39239
@vstinner vstinner force-pushed the vstinner:epoll_ebadf branch from bdcbf9e to 2e607ff Jan 6, 2020
@vstinner
bpo-39239: epoll.unregister() no longer ignores EBADF
Loading status checks…
dcf6802 
The select.epoll.unregister() method no longer ignores the EBADF
error.
@vstinner vstinner force-pushed the vstinner:epoll_ebadf branch from 2e607ff to dcf6802 Jan 7, 2020
@vstinner

This comment has been minimized.

Sign in to view
Copy link
Member Author

vstinner commented Jan 7, 2020

cc @tiran @giampaolo @pitrou
@tiran
tiran approved these changes Jan 7, 2020
View changes
Copy link
Member

tiran left a comment

I don't recall why I ignored EBADF here. Victor has made a compelling argument to stop ignoring the error. I trust his judgement.
@vstinner

This comment has been minimized.

Sign in to view
Copy link
Member Author

vstinner commented Jan 7, 2020

cc @1st1 @asvetlov
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiran tiran

Assignees
No one assigned
Labels
CLA signed awaiting merge
Projects
None yet
Milestone
No milestone
4 participants
@vstinner @tiran @the-knights-who-say-ni @bedevere-bot
You can’t perform that action at this time.