Skip to content

/ cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-39209: Manage correctly multi-line tokens in interactive mode #17860

Merged
merged 2 commits into from Jan 6, 2020
Merged

bpo-39209: Manage correctly multi-line tokens in interactive mode #17860

merged 2 commits into from Jan 6, 2020
+40 −0

Conversation

@pablogsal
Copy link
Member

pablogsal commented Jan 6, 2020 •
edited by bedevere-bot

https://bugs.python.org/issue39209
@pablogsal

This comment has been minimized.

Sign in to view
Copy link
Member Author

pablogsal commented Jan 6, 2020

CC: @corona10

Could you check if this fixes the problem on your system?
@pablogsal
bpo-39209: Manage correctly multi-line tokens in interactive mode
Loading status checks…
13dadaa
@pablogsal pablogsal force-pushed the pablogsal:bpo-39209 branch from b43a5b2 to 13dadaa Jan 6, 2020
@corona10

This comment has been minimized.

Sign in to view
Copy link
Member

corona10 commented Jan 6, 2020

@pablogsal I will report it by today :)
@pablogsal
Add regression test
Loading status checks…
958541d
@pablogsal pablogsal force-pushed the pablogsal:bpo-39209 branch from e19a317 to 958541d Jan 6, 2020
@corona10

This comment has been minimized.

Sign in to view
Copy link
Member

corona10 commented Jan 6, 2020

@pablogsal Work correctly with this PR :)
@corona10
corona10 approved these changes Jan 6, 2020
View changes
Copy link
Member

corona10 left a comment

lgtm
@asottile
asottile approved these changes Jan 6, 2020
View changes
@pablogsal pablogsal self-assigned this Jan 6, 2020
@pablogsal pablogsal merged commit 5ec91f7 into python:master Jan 6, 2020
9 checks passed
9 checks passed
Docs
Details
Windows (x86)
Details
Windows (x64)
Details
macOS
Details
Ubuntu
Details
Azure Pipelines PR #20200106.16 succeeded
Details
bedevere/issue-number Issue number 39209 found
Details
bedevere/news News entry found in Misc/NEWS.d
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@pablogsal pablogsal deleted the pablogsal:bpo-39209 branch Jan 6, 2020
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Jan 6, 2020

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Jan 6, 2020

GH-17867 is a backport of this pull request to the 3.8 branch.
miss-islington added a commit that referenced this pull request Jan 6, 2020
@miss-islington @pablogsal
bpo-39209: Manage correctly multi-line tokens in interactive mode (GH…
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
b2e281a 
…-17860)

(cherry picked from commit 5ec91f7)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
gousaiyang added a commit to gousaiyang/cpython that referenced this pull request Jan 8, 2020
@pablogsal @gousaiyang
bpo-39209: Manage correctly multi-line tokens in interactive mode (py…
c729d41 
…thonGH-17860)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asottile asottile

@corona10 corona10

Assignees

@pablogsal pablogsal

Labels
CLA signed
Projects
None yet
Milestone
No milestone
6 participants
@pablogsal @corona10 @miss-islington @bedevere-bot @asottile @the-knights-who-say-ni
You can’t perform that action at this time.