Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upbpo-38870: Simplify tuple like interleaves, roundtrip extslice properly #17892
+20
−12
Conversation
Co-Authored-By: Pablo Galindo <Pablogsal@gmail.com>
This comment has been minimized.
This comment has been minimized.
Thanks for the suggestions @pablogsal! |
self.write(",") | ||
else: | ||
self.interleave(lambda: self.write(", "), self._write_constant, value) | ||
self.items_view(self._write_constant, value) |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
pablogsal
Jan 7, 2020
Member
as I stated in the issue, no
Then shouldn't we add that code once the test can be added?
This comment has been minimized.
This comment has been minimized.
isidentical
Jan 7, 2020
Author
Contributor
We already had some missing tests, including constant tuples.
This comment has been minimized.
This comment has been minimized.
pablogsal
Jan 7, 2020
Member
We already had some missing tests, including constant tuples.
That does not justify adding even more missing test IMHO ;)
This comment has been minimized.
This comment has been minimized.
isidentical
Jan 7, 2020
Author
Contributor
We already dont have tests for that,
Yes, unfortunately it isn't :/ Lets wait one of the PRs I mentioned before and we can add tests for constant tuples.
This comment has been minimized.
This comment has been minimized.
The build is failing because you have trailing whitespace (you can run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
isidentical commentedJan 7, 2020
•
edited by bedevere-bot
https://bugs.python.org/issue38870