Skip to content

/ cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace links in howto/pyporting.rst with sphinx references #17781

Merged
merged 1 commit into from Jan 5, 2020
Merged

replace links in howto/pyporting.rst with sphinx references #17781

merged 1 commit into from Jan 5, 2020

Conversation

@hoefling
Copy link
Contributor

hoefling commented Jan 1, 2020

The howto/pyporting.rst documentation uses hardcoded links to internal pages. This results in minor rendering issues. This change replaces the hardcoded links with suitable Sphinx roles.

This is the second and last PR that replaces hardcoded links to internal pages (the first one was #11730). I did create neither an issue on BPO nor a news entry as the fix is IMO a trivial one.
@hoefling
replace links in howto/pyporting.rst with sphinx references
Verified
This commit was signed with a verified signature.
hoefling Oleg Höfling
GPG key ID: 0F2974E780119EEA Learn about signing commits
Loading status checks…
ec36d43 
Signed-off-by: Oleg Höfling <oleg.hoefling@gmail.com>
@csabella
csabella approved these changes Jan 5, 2020
View changes
Copy link
Contributor

csabella left a comment

LGTM. Thank you for the contribution!
@csabella csabella merged commit e6ae90d into python:master Jan 5, 2020
5 checks passed
5 checks passed
Docs
Details
Azure Pipelines PR #20200101.10 succeeded
Details
bedevere/issue-number Issue report skipped
bedevere/news "skip news" label found
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Jan 5, 2020

Thanks @hoefling for the PR, and @csabella for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Jan 5, 2020

GH-17844 is a backport of this pull request to the 3.8 branch.
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Jan 5, 2020

GH-17845 is a backport of this pull request to the 3.7 branch.
miss-islington added a commit to miss-islington/cpython that referenced this pull request Jan 5, 2020
@hoefling @miss-islington
Replace links in howto/pyporting.rst with sphinx references (pythonGH…
d5a695f 
…-17781)

Signed-off-by: Oleg Höfling <oleg.hoefling@gmail.com>
(cherry picked from commit e6ae90d)

Co-authored-by: Oleg Höfling <hoefling@users.noreply.github.com>
miss-islington added a commit that referenced this pull request Jan 5, 2020
@miss-islington @hoefling
Replace links in howto/pyporting.rst with sphinx references (GH-17781)
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
cb4ed24 
Signed-off-by: Oleg Höfling <oleg.hoefling@gmail.com>
(cherry picked from commit e6ae90d)

Co-authored-by: Oleg Höfling <hoefling@users.noreply.github.com>
miss-islington added a commit that referenced this pull request Jan 5, 2020
@miss-islington @hoefling
Replace links in howto/pyporting.rst with sphinx references (GH-17781)
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
183fbd1 
Signed-off-by: Oleg Höfling <oleg.hoefling@gmail.com>
(cherry picked from commit e6ae90d)

Co-authored-by: Oleg Höfling <hoefling@users.noreply.github.com>
gousaiyang added a commit to gousaiyang/cpython that referenced this pull request Jan 8, 2020
@hoefling @gousaiyang
Replace links in howto/pyporting.rst with sphinx references (pythonGH…
283da09 
…-17781)

Signed-off-by: Oleg Höfling <oleg.hoefling@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csabella csabella

Assignees
No one assigned
Labels
CLA signed skip issue skip news type-documentation
Projects
None yet
Milestone
No milestone
5 participants
@hoefling @miss-islington @bedevere-bot @csabella @the-knights-who-say-ni
You can’t perform that action at this time.