Skip to content

/ cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further improve clarity of try-return-finally-return #17921

Open
wants to merge 4 commits into
base: master
from
Open

Further improve clarity of try-return-finally-return #17921

wants to merge 4 commits into from
+12 −2

Conversation

@toonarmycaptain
Copy link
Contributor

toonarmycaptain commented Jan 9, 2020

This stackoverflow question suggests that this explanation may be made clearer.
@toonarmycaptain
Improve clarity of try-return-finally-return
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
946f614 
[This stackoverflow question](https://stackoverflow.com/questions/59639733/python-docs-have-misleading-explanation-of-return-in-finally) suggests that this explanation may be made clearer.
@toonarmycaptain
Remove trailing whitespace.
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
d264302
@toonarmycaptain
Remove space between :keyword: and `return`
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
5dd29dc
@toonarmycaptain

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

toonarmycaptain commented Jan 9, 2020 •
edited

I has been suggested that

  • If a :keyword:finally clause includes a :keyword:return statement, the :keyword:finally clause's :keyword:return statement will execute instead of, the :keyword:return statement in a :keyword:try clause (but after the value of the :keyword:try clause's :keyword:return statement is evaluated).

Might be clearer if phrased simply

  • If both :keyword:try and :keyword:finally return a value, the :keyword:return value from the :keyword:finally block is returned.
@toonarmycaptain
Clarify try/finally return statements
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
f4a6746 
A finally return statement is the last one executed in terms of evaluating the expression, but it is the *only* one executed in terms of returning a value.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA signed awaiting review type-documentation
Projects
None yet
Milestone
No milestone
3 participants
@toonarmycaptain @the-knights-who-say-ni @bedevere-bot
You can’t perform that action at this time.