Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upbpo-39130: Dict reversed was added in v3.8 so should say in the doc as well #17694
Conversation
This comment has been minimized.
This comment has been minimized.
the-knights-who-say-ni
commented
Dec 24, 2019
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). CLA MissingOur records indicate the following people have not signed the CLA: For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. If you have recently signed the CLA, please wait at least one business day You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
|
LGTM. This is more noticeable though there is an example with |
|
Thanks for the PR @khalidmammadov and welcome! LGTM. This feature was clearly documented in the What's New for 3.8, so it should definitely have a versionadded tag in a highly visible location: https://docs.python.org/3/whatsnew/3.8.html#other-language-changes. |
This comment has been minimized.
This comment has been minimized.
Agreed. The versionadded in this PR is definitely much more visible than the present one, which is easy to miss since it's not near the main definition. |
|
Thank you for the contribution, @khalidmammadov! |
This comment has been minimized.
This comment has been minimized.
miss-islington
commented
Jan 5, 2020
|
Thanks @khalidmammadov for the PR |
This comment has been minimized.
This comment has been minimized.
bedevere-bot
commented
Jan 5, 2020
|
GH-17848 is a backport of this pull request to the 3.8 branch. |
…s well (GH-17694) To be consistent with document layout, it should say when the feature was added. Although it's mentioned few other places in the doc but it's not explicitly say that at that place. https://bugs.python.org/issue39130 (cherry picked from commit 94d9cfc) Co-authored-by: Khalid Mammadov <khalidmammadov9@gmail.com>
…s well (pythonGH-17694) To be consistent with document layout, it should say when the feature was added. Although it's mentioned few other places in the doc but it's not explicitly say that at that place. https://bugs.python.org/issue39130
khalidmammadov commentedDec 24, 2019
•
edited by miss-islington
To be consistent with document layout, it should say when the feature was added.
Although it's mentioned few other places in the doc but it's not explicitly say that at that place.
https://bugs.python.org/issue39130
Automerge-Triggered-By: @csabella