Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-30731: python.manifest fix #2328

Merged
merged 2 commits into from Jul 13, 2017
Merged

bpo-30731: python.manifest fix #2328

merged 2 commits into from Jul 13, 2017

Conversation

segevfiner
Copy link
Contributor

@segevfiner segevfiner commented Jun 22, 2017

I'm not seeing the typo mentioned in the issue (PC/python.manifest:3) but the xmlns is missing so I added it. Also trimmed some trailing whitespace because really...

For reference, here is a manifest generated by default on stuff built with VS2015:

<?xml version='1.0' encoding='UTF-8' standalone='yes'?>
<assembly xmlns='urn:schemas-microsoft-com:asm.v1' manifestVersion='1.0'>
  <trustInfo xmlns="urn:schemas-microsoft-com:asm.v3">
    <security>
      <requestedPrivileges>
        <requestedExecutionLevel level='asInvoker' uiAccess='false' />
      </requestedPrivileges>
    </security>
  </trustInfo>
</assembly>

Documentation on this seems surprisingly poor on MSDN. Or maybe I just failed to find it...

@mention-bot
Copy link

mention-bot commented Jun 22, 2017

@segevfiner, thanks for your PR! By analyzing the history of the files in this pull request, we identified @zooba to be a potential reviewer.

@zooba
Copy link
Member

zooba commented Jul 13, 2017

I want to merge this, but now it has a bug it needs a NEWS.d entry. Can you add one?

@zooba zooba merged commit c40ad03 into python:master Jul 13, 2017
@zooba
Copy link
Member

zooba commented Jul 13, 2017

Thanks!

zooba pushed a commit to zooba/cpython that referenced this pull request Jul 13, 2017
@segevfiner @zooba
bpo-30731: python.manifest fix (python#2328)
c097261 
bpo-30731: python.manifest fix
zooba added a commit that referenced this pull request Jul 13, 2017
@zooba
bpo-30731: python.manifest fix (#2328) (#2699)
d8e522f 
bpo-30731: python.manifest fix
@segevfiner segevfiner deleted the bpo-30731-manifest branch Jul 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@segevfiner @mention-bot @zooba @Mariatta @the-knights-who-say-ni