Skip to content

/ cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in multiprocessing.pool.AsyncResult.successful doc. #17932

Open
wants to merge 1 commit into
base: master
from
Open

Fix typo in multiprocessing.pool.AsyncResult.successful doc. #17932

wants to merge 1 commit into from
+1 −1

Conversation

@awecx
Copy link
Contributor

awecx commented Jan 9, 2020 •
edited

Since 3.7 successful raises a ValueError as explained in the next text block from the documentation:

Changed in version 3.7: If the result is not ready, ValueError is raised instead of AssertionError.

No issue associated with this PR.
Should be backported in 3.7 and 3.8.
@awecx
Fix typo in successful() reference doc.
Loading status checks…
293862e
@aeros
aeros approved these changes Jan 9, 2020
View changes
Copy link
Member

aeros left a comment •
edited

Thanks for the PR @awecx.

I confirmed from the source code that AsyncResult.successful() does indeed raise a ValueError instead of an AssertionError:

cpython/Lib/multiprocessing/pool.py

Lines 753 to 756 in a796d8e

def successful(self):
if not self.ready():
raise ValueError("{0!r} not ready".format(self))
return self._success

LGTM. This is also present in the 3.8 and 3.7 branches, so this PR should be backported to those versions as well.
@aeros aeros assigned pitrou and unassigned pitrou Jan 9, 2020
@aeros aeros requested a review from pitrou Jan 9, 2020
@aeros

This comment has been minimized.

Sign in to view
Copy link
Member

aeros commented Jan 9, 2020

Added @pitrou as a reviewer for the PR, since he's an active expert for the multiprocessing module.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aeros aeros

@pitrou pitrou

Assignees
No one assigned
Labels
CLA signed awaiting core review needs backport to 3.7 needs backport to 3.8 skip issue skip news type-documentation
Projects
None yet
Milestone
No milestone
5 participants
@awecx @aeros @pitrou @the-knights-who-say-ni @bedevere-bot
You can’t perform that action at this time.