Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upbpo-39279: Don't allow non-Ascii digits in platform.py #17928
+5
−4
Conversation
This comment has been minimized.
This comment has been minimized.
|
@ezio-melotti @bitdancer This touches code that you were the last to touch, a few years ago. Care to comment? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
cool-RR commentedJan 9, 2020
•
edited by bedevere-bot
The
platform.pymodule takes non-Ascii digits in regexes in places it shouldn't. e.g. digits like ٢ and ５ and accepted, when only the Ascii digits between 0-9 should be accepted.https://bugs.python.org/issue39279