Perfect your code
With built-in code review tools, GitHub makes it easy to raise the quality bar before you ship. Join the 40 million developers who've merged over 200 million pull requests.
Sign up for free See pricing for teams and enterprisesFix typo in multiprocessing.pool.AsyncResult.successful doc. #17932
Conversation
Thanks for the PR @awecx. I confirmed from the source code that cpython/Lib/multiprocessing/pool.py Lines 753 to 756 in a796d8e LGTM. This is also present in the 3.8 and 3.7 branches, so this PR should be backported to those versions as well. |
This comment has been minimized.
This comment has been minimized.
Added @pitrou as a reviewer for the PR, since he's an active expert for the multiprocessing module. |
This comment has been minimized.
This comment has been minimized.
Thanks @aeros for the clarification. Indeed I should have proven the typo claim more clearly:
|
awecx commentedJan 9, 2020
•
edited
Since 3.7
successful
raises aValueError
as explained in the next text block from the documentation:Changed in version 3.7: If the result is not ready, ValueError is raised instead of AssertionError.
No issue associated with this PR.
Should be backported in 3.7 and 3.8.