bpo-39259: nntplib.NNTP/NNTP_SSL now reject timeout = 0

bpo-39259: Update docs
python · corona10 · corona10 · corona10 · Jan 10, 2020 · the-knights-who-say-ni
diff --git a/Lib/nntplib.py b/Lib/nntplib.py
+    def _create_socket(self, timeout):
+        if timeout is not None and not timeout:
+            raise ValueError('Non-blocking socket (timeout=0) is not supported')
+        return socket.create_connection((self.host, self.port), timeout)
diff --git a/Lib/nntplib.py b/Lib/nntplib.py
+                          usenetrc, timeout)
+
+        def _create_socket(self, timeout):
+            self.sock = NNTP._create_socket(self, timeout)
-            self.sock = NNTP._create_socket(self, timeout)
+            self.sock = super()._create_socket(timeout)
diff --git a/Lib/nntplib.py b/Lib/nntplib.py
-            finally:
-                self.sock.close()
+            self.ssl_context = ssl_context
+            NNTP.__init__(self, host, port, user, password, readermode,
-            NNTP.__init__(self, host, port, user, password, readermode,
+            super().__init__(host, port, user, password, readermode,
diff --git a/Lib/nntplib.py b/Lib/nntplib.py
+
+        def _create_socket(self, timeout):
+            self.sock = NNTP._create_socket(self, timeout)
+            self.sock = _encrypt_on(self.sock, self.ssl_context, self.host)