bpo-38468 : Refactor python-config #16749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pablogsal
reviewed
Oct 14, 2019
Misc/NEWS.d/next/Build/2019-10-13-16-18-24.bpo-38468.buCO84.rst
Outdated
Show resolved
Hide resolved
Co-Authored-By: Pablo Galindo <Pablogsal@gmail.com>
|
Thanks @pablogsal |
vstinner
reviewed
Oct 14, 2019
vstinner
reviewed
Oct 15, 2019
Misc/NEWS.d/next/Build/2019-10-13-16-18-24.bpo-38468.buCO84.rst
Outdated
Show resolved
Hide resolved
vstinner
reviewed
Oct 15, 2019
Misc/NEWS.d/next/Build/2019-10-13-16-18-24.bpo-38468.buCO84.rst
Outdated
Show resolved
Hide resolved
Co-Authored-By: Victor Stinner <vstinner@python.org>
vstinner
reviewed
Oct 15, 2019
| Use `getvar` for all still existing `sysconfig.get_config_var()` calls. | ||
| The affected file is `Python3.9-config.in`. | ||
| Misc/python-config.in now uses `getvar` for all still existing `sysconfig.get_config_var()` calls. | ||
| Patch by Joannah Nanjekye |
There was a problem hiding this comment.
Something gone wrong :-/ I only expected 2 lines for this file, not 4. Maybe I shouldn't use GitHub "suggestion" on multiple lines :-( I expected:
Misc/python-config.in now uses `getvar()` for all still existing `sysconfig.get_config_var()` calls.
Patch by Joannah Nanjekye.
|
@nanjekyejoannah: Please replace |
jacobneiltaylor
pushed a commit
to jacobneiltaylor/cpython
that referenced
this issue
Dec 5, 2019
* refactor python-config *📜 🤖 Added by blurb_it. * Update Misc/NEWS.d/next/Build/2019-10-13-16-18-24.bpo-38468.buCO84.rst Co-Authored-By: Pablo Galindo <Pablogsal@gmail.com> * Use getvar for pyver * Update news entry with affected file. * Update Misc/NEWS.d/next/Build/2019-10-13-16-18-24.bpo-38468.buCO84.rst Co-Authored-By: Victor Stinner <vstinner@python.org> * Update 2019-10-13-16-18-24.bpo-38468.buCO84.rst
shihai1991
pushed a commit
to shihai1991/cpython
that referenced
this issue
Jan 31, 2020
* refactor python-config *📜 🤖 Added by blurb_it. * Update Misc/NEWS.d/next/Build/2019-10-13-16-18-24.bpo-38468.buCO84.rst Co-Authored-By: Pablo Galindo <Pablogsal@gmail.com> * Use getvar for pyver * Update news entry with affected file. * Update Misc/NEWS.d/next/Build/2019-10-13-16-18-24.bpo-38468.buCO84.rst Co-Authored-By: Victor Stinner <vstinner@python.org> * Update 2019-10-13-16-18-24.bpo-38468.buCO84.rst
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Use
getvarfor all still existingsysconfig.get_config_var()calls .https://bugs.python.org/issue38468