Skip to content

/ cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-39235: Check end_lineno and end_col_offset of AST nodes. #17926

Open
wants to merge 3 commits into
base: master
from
Open

bpo-39235: Check end_lineno and end_col_offset of AST nodes. #17926

wants to merge 3 commits into from

Conversation

@serhiy-storchaka
Copy link
Member

serhiy-storchaka commented Jan 9, 2020 •
edited by bedevere-bot

https://bugs.python.org/issue39235
@serhiy-storchaka
bpo-39235 Check end_lineno and end_col_offset of AST nodes.
Loading status checks…
168e424
@serhiy-storchaka serhiy-storchaka requested a review from gvanrossum Jan 9, 2020
@serhiy-storchaka serhiy-storchaka changed the title bpo-39235 Check end_lineno and end_col_offset of AST nodes. bpo-39235: Check end_lineno and end_col_offset of AST nodes. Jan 9, 2020
@serhiy-storchaka serhiy-storchaka mentioned this pull request Jan 9, 2020
Merged
@gvanrossum
gvanrossum approved these changes Jan 9, 2020
View changes
@gvanrossum

This comment has been minimized.

Sign in to view
Copy link
Member

gvanrossum commented Jan 9, 2020

Should this be backported to 3.8?

Which should be merged first, this one or GH-17925?

Should I still add the test that @pablogsal suggested in GH-17925?
@serhiy-storchaka
Merge branch 'master' into test-ast-end
dd55f7e
@serhiy-storchaka
Update tests for bpo-39235.
Loading status checks…
bab2c12
@serhiy-storchaka

This comment has been minimized.

Sign in to view
Copy link
Member Author

serhiy-storchaka commented Jan 9, 2020

I do not want to backport this, because I am not sure that all end positions are correct. If there are incorrect end positions, this can break tests for alternate Python implementations which calculate them correctly.

bab2c12 shows the effect of #17925.
@gvanrossum

This comment has been minimized.

Sign in to view
Copy link
Member

gvanrossum commented Jan 9, 2020

OK. I suppose you have to recalculate now that GH-17925 has landed?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gvanrossum gvanrossum

Assignees
No one assigned
Labels
CLA signed awaiting merge skip news type-tests
Projects
None yet
Milestone
No milestone
4 participants
@serhiy-storchaka @gvanrossum @the-knights-who-say-ni @bedevere-bot
You can’t perform that action at this time.