Skip to content

/ cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-34977: Add Windows App Store package #11027

Merged
merged 6 commits into from Dec 11, 2018
Merged

bpo-34977: Add Windows App Store package #11027

merged 6 commits into from Dec 11, 2018
+2,928 −405

Conversation

@zooba
Copy link
Member

zooba commented Dec 7, 2018 •
edited by bedevere-bot

Restores the original commit, plus the fix to ensure that when building on machines without recent MSVC/WinSDK we don't fail.

https://bugs.python.org/issue34977
@zooba zooba requested a review from python/windows-team as a code owner Dec 7, 2018
@vstinner
vstinner reviewed Dec 7, 2018
View changes
Copy link
Member

vstinner left a comment

Please move the venv and tests change into a separated PR.
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Dec 7, 2018

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.
@vstinner
vstinner reviewed Dec 7, 2018
View changes
PC/launcher.c Outdated Show resolved Hide resolved
@vstinner

This comment has been minimized.

Sign in to view
Copy link
Member

vstinner commented Dec 7, 2018

Please run a custom build on buildbot before merging this PR, I would prefer to not have to revert the change one more time :-)
https://bugs.python.org/issue34977#msg331322
@zooba

This comment has been minimized.

Sign in to view
Copy link
Member Author

zooba commented Dec 7, 2018

How do you trigger a custom build these days? I couldn't find the UI.
@vstinner

This comment has been minimized.

Sign in to view
Copy link
Member

vstinner commented Dec 7, 2018

How do you trigger a custom build these days? I couldn't find the UI.

It's basically just a Git push to the right branch:

$ git push upstream <local_branch_name>:buildbot-custom

See https://devguide.python.org/buildbots/#custom-builders for more info.

Then you can go to https://buildbot.python.org/all/#/builders for example to see results: check the custom workers ran your job and check that they are green ;-) You should ignore unstable buildbots like Alpine or Clang UBSan custom. Well, we mostly care about Windows here :-)
@zooba zooba mentioned this pull request Dec 7, 2018
Merged
@zooba zooba force-pushed the zooba:bpo34977 branch from 565e7ba to a859831 Dec 8, 2018
@zooba
bpo-34977: Add Windows App Store package (GH-10245)
Loading status checks…
c8bc5e7
@zooba zooba force-pushed the zooba:bpo34977 branch from a859831 to c8bc5e7 Dec 10, 2018
zooba added a commit to zooba/cpython that referenced this pull request Dec 10, 2018
@zooba
bpo-34977: Add Windows App Store package (pythonGH-11027)
c5718e5
@zooba

This comment has been minimized.

Sign in to view
Copy link
Member Author

zooba commented Dec 10, 2018

I have made the requested changes; please review again
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Dec 10, 2018

Thanks for making the requested changes!

@vstinner: please review the changes made to this pull request.
zooba added 3 commits Dec 10, 2018
@zooba
Update Windows installation section to cover different installers
Loading status checks…
7d7ddbc
@zooba
Fixes double backslash
Loading status checks…
138faab
@zooba
Exclude UWP launchers when not generating APPX layout
Loading status checks…
4508e85
@pfmoore
pfmoore approved these changes Dec 10, 2018
View changes
Copy link
Member

pfmoore left a comment

A couple of minor points, but generally this looks OK to me.
Doc/using/windows.rst Outdated Show resolved Hide resolved
Doc/using/windows.rst Outdated Show resolved Hide resolved
@zooba
Improve wording in new docs
Loading status checks…
b41de62
@zooba zooba dismissed vstinner’s stale review Dec 11, 2018

Outdated

@zooba
Fix incorrect reference to 3.8.2
Loading status checks…
8272d13
@zooba zooba merged commit 0cd6391 into python:master Dec 11, 2018
5 checks passed
5 checks passed
Azure Pipelines PR #20181211.1 succeeded
Details
bedevere/issue-number Issue number 34977 found
Details
bedevere/news News entry found in Misc/NEWS.d
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@zooba zooba deleted the zooba:bpo34977 branch Dec 11, 2018
zooba added a commit that referenced this pull request Dec 11, 2018
@zooba
bpo-34977: Add Windows App Store package (GH-11027)
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
0e4ad88 
Also adds the PC/layout script for generating layouts on Windows.
@saschanaz saschanaz mentioned this pull request May 25, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner

@pfmoore pfmoore

Assignees
No one assigned
Labels
CLA signed
Projects
None yet
Milestone
No milestone
5 participants
@zooba @bedevere-bot @vstinner @pfmoore @the-knights-who-say-ni
You can’t perform that action at this time.