Skip to content

bpo-38419: fix "check-c-globals" path #16680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 23, 2019
Merged

bpo-38419: fix "check-c-globals" path #16680

merged 1 commit into from
Oct 23, 2019

Conversation

amiremohamadi
Copy link
Contributor

@amiremohamadi amiremohamadi commented Oct 9, 2019 •
edited
Loading

fix "check-c-globals" path:
Tools/c-analyzer/check-c-globals.py instead of Tools/c-globals/check-c-globals.py

https://bugs.python.org/issue38419

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@amiremohamadi

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@brandtbucher
Copy link
Member

brandtbucher commented Oct 9, 2019 •
edited
Loading

Thanks for your time @amiremohamadi, and welcome to CPython! 😎

I assume that you've seen the bot's message about the CLA?

brandtbucher
brandtbucher approved these changes Oct 9, 2019
View reviewed changes
Copy link
Member

@brandtbucher brandtbucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a good change to me!

@brandtbucher brandtbucher added the docs Documentation in the Doc dir label Oct 9, 2019
corona10
corona10 approved these changes Oct 10, 2019
View reviewed changes
Copy link
Member

@corona10 corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shihai1991
shihai1991 approved these changes Oct 10, 2019
View reviewed changes
Copy link
Member

@shihai1991 shihai1991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1.

willingc
willingc approved these changes Oct 23, 2019
View reviewed changes
Copy link
Contributor

@willingc willingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR and contribution @amiremohamadi.

Triagers, Thanks for the reviews too.

@willingc willingc merged commit 20bf8e0 into python:master Oct 23, 2019
@brandtbucher
Copy link
Member

Congrats on your first CPython contribution @amiremohamadi! 🍾

Looking forward to seeing more from you in the future.

jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
@amiremohamadi
bpo-38419: fix "check-c-globals" path (pythonGH-16680)
0593ea8
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
@amiremohamadi @shihai1991
bpo-38419: fix "check-c-globals" path (pythonGH-16680)
b2805a6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willingc willingc willingc approved these changes

@corona10 corona10 corona10 approved these changes

@shihai1991 shihai1991 shihai1991 approved these changes

@brandtbucher brandtbucher brandtbucher approved these changes

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@amiremohamadi @the-knights-who-say-ni @brandtbucher @willingc @corona10 @shihai1991 @bedevere-bot