Skip to content

/ cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-39234: `enum.auto()` default initial value as 1 #17878

Merged
merged 5 commits into from Jan 6, 2020
Merged

bpo-39234: `enum.auto()` default initial value as 1 #17878

merged 5 commits into from Jan 6, 2020

Conversation

@YoSTEALTH
Copy link
Contributor

YoSTEALTH commented Jan 6, 2020 •
edited by miss-islington

Updated as Eric mentioned "By default, the initial value starts at 1"

https://bugs.python.org/issue39234

Automerge-Triggered-By: @ericvsmith
YoSTEALTH added 3 commits Jan 6, 2020
@YoSTEALTH
`enum.auto()` incrementation value not specified.
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
d3ed9d3 
enum in C starts at 0, while `enum.auto()` in Python starts at 1, thus needs to be specified.
@YoSTEALTH
updated content as per Eric comment.
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
3f10a68
@YoSTEALTH
updated content "by deault..."
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
7a28afc
@YoSTEALTH YoSTEALTH requested a review from ethanfurman as a code owner Jan 6, 2020
@YoSTEALTH

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

YoSTEALTH commented Jan 6, 2020

@ethanfurman this should back-port all the way to 3.6 as enum.auto() was first added in 3.6
@YoSTEALTH YoSTEALTH mentioned this pull request Jan 6, 2020
Merged
@ericvsmith
ericvsmith reviewed Jan 6, 2020
View changes
Doc/library/enum.rst Outdated
@@ -55,7 +55,7 @@ helper, :class:`auto`.

.. class:: auto

Instances are replaced with an appropriate value for Enum members.
Instances are replaced with an appropriate value for Enum members. By default, the initial value starts at 1

This comment has been minimized.

Sign in to view
Copy link
@ericvsmith

ericvsmith Jan 6, 2020

Member

You're missing the trailing period. Sorry for all of the minor fixes.

This comment has been minimized.

Sign in to view
Copy link
@YoSTEALTH

YoSTEALTH Jan 6, 2020

Author Contributor

no worries, added the "."
thanks Eric
@YoSTEALTH
added "."
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
5038e04
@ericvsmith
ericvsmith approved these changes Jan 6, 2020
View changes
@ericvsmith
Merge branch 'master' into patch-1
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
1226195
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Jan 6, 2020

@YoSTEALTH: Status check is done, and it's a success ✅ .
@miss-islington miss-islington merged commit 24bcefc into python:master Jan 6, 2020
5 checks passed
5 checks passed
Docs
Details
Azure Pipelines PR #20200106.54 succeeded
Details
bedevere/issue-number Issue number 39234 found
Details
bedevere/news "skip news" label found
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Jan 6, 2020

Thanks @YoSTEALTH for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7, 3.8.
🐍🍒⛏🤖
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Jan 6, 2020

Sorry, @YoSTEALTH, I could not cleanly backport this to 3.8 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 24bcefcb74231476b055bb6f0726642abeb10f04 3.8
@miss-islington miss-islington self-assigned this Jan 6, 2020
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Jan 6, 2020

Sorry @YoSTEALTH, I had trouble checking out the 3.7 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 24bcefcb74231476b055bb6f0726642abeb10f04 3.7
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Jan 6, 2020

Sorry, @YoSTEALTH, I could not cleanly backport this to 3.6 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 24bcefcb74231476b055bb6f0726642abeb10f04 3.6
ericvsmith added a commit to ericvsmith/cpython that referenced this pull request Jan 7, 2020
@YoSTEALTH @ericvsmith
[3.8] bpo-39234: `enum.auto()` default initial value as 1 (pythonGH-1…
d370445 
…7878)

Updated as Eric mentioned "By default, the initial value starts at 1"

https://bugs.python.org/issue39234

Automerge-Triggered-By: @ericvsmith.
(cherry picked from commit 24bcefc)

Co-authored-by: YoSTEALTH <35307184+YoSTEALTH@users.noreply.github.com>
ericvsmith added a commit that referenced this pull request Jan 7, 2020
@YoSTEALTH @ericvsmith
[3.8] bpo-39234: `enum.auto()` default initial value as 1 (GH-17878)
ef34ce7 
Updated as Eric mentioned "By default, the initial value starts at 1"

https://bugs.python.org/issue39234

Automerge-Triggered-By: @ericvsmith.
(cherry picked from commit 24bcefc)

Co-authored-by: YoSTEALTH <35307184+YoSTEALTH@users.noreply.github.com>
ericvsmith added a commit that referenced this pull request Jan 7, 2020
@YoSTEALTH @ericvsmith
[3.7] bpo-39234: `enum.auto()` default initial value as 1 (GH-17878)
50023ff 
Updated as Eric mentioned "By default, the initial value starts at 1"

https://bugs.python.org/issue39234

Automerge-Triggered-By: @ericvsmith.
(cherry picked from commit 24bcefc)

Co-authored-by: YoSTEALTH <35307184+YoSTEALTH@users.noreply.github.com>
ericvsmith added a commit that referenced this pull request Jan 7, 2020
@YoSTEALTH @ericvsmith
[3.6] bpo-39234: `enum.auto()` default initial value as 1 (GH-17878)
8953d06 
Updated as Eric mentioned "By default, the initial value starts at 1"

https://bugs.python.org/issue39234

Automerge-Triggered-By: @ericvsmith.
(cherry picked from commit 24bcefc)

Co-authored-by: YoSTEALTH <35307184+YoSTEALTH@users.noreply.github.com>
gousaiyang added a commit to gousaiyang/cpython that referenced this pull request Jan 8, 2020
@YoSTEALTH @gousaiyang
bpo-39234: `enum.auto()` default initial value as 1 (pythonGH-17878)
7ab509b 
Updated as Eric mentioned "By default, the initial value starts at 1"


https://bugs.python.org/issue39234



Automerge-Triggered-By: @ericvsmith
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericvsmith ericvsmith

@ethanfurman ethanfurman

Assignees

@miss-islington miss-islington

Labels
🤖 automerge CLA signed needs backport to 3.6 needs backport to 3.7 needs backport to 3.8 skip news type-documentation
Projects
None yet
Milestone
No milestone
5 participants
@YoSTEALTH @miss-islington @ericvsmith @the-knights-who-say-ni @bedevere-bot
You can’t perform that action at this time.