Skip to content

/ cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor: fix typo in test doc, fix flake8 issues #17856

Merged
merged 2 commits into from Jan 9, 2020
Merged

minor: fix typo in test doc, fix flake8 issues #17856

merged 2 commits into from Jan 9, 2020
+1 −1

Conversation

@blueyed
Copy link
Contributor

blueyed commented Jan 6, 2020

No description provided.

@blueyed
minor: fix typo in test doc, fix flake8 issues
Loading status checks…
944f978
@tirkarthi

This comment has been minimized.

Sign in to view
Copy link
Contributor

tirkarthi commented Jan 6, 2020

Typo fix LGTM. I am not sure the whitespace changes are needed. There are other parts in stdlib that are also not flake8 compliant.
@blueyed
revert whitespace fixes
Loading status checks…
08c1991
@blueyed

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

blueyed commented Jan 6, 2020

ok, reverted - I've just thought it could be also fixed while at it.
@tirkarthi
tirkarthi approved these changes Jan 6, 2020
View changes
Copy link
Contributor

tirkarthi left a comment

LGTM. Thanks.
@tirkarthi tirkarthi merged commit 2f65aa4 into python:master Jan 9, 2020
8 checks passed
8 checks passed
Windows (x86)
Details
Windows (x64)
Details
macOS
Details
Ubuntu
Details
Azure Pipelines PR #20200106.25 succeeded
Details
bedevere/issue-number Issue report skipped
bedevere/news "skip news" label found
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Jan 9, 2020

Thanks @blueyed for the PR, and @tirkarthi for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖
miss-islington added a commit to miss-islington/cpython that referenced this pull request Jan 9, 2020
@blueyed @miss-islington
Fix typo in test's docstring (pythonGH-17856)
1a57b21 
* Fix typo in test's docstring. contination -> continuation.
(cherry picked from commit 2f65aa4)

Co-authored-by: Daniel Hahler <git@thequod.de>
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Jan 9, 2020

GH-17923 is a backport of this pull request to the 3.8 branch.
@tirkarthi

This comment has been minimized.

Sign in to view
Copy link
Contributor

tirkarthi commented Jan 9, 2020

Thanks @blueyed :)
tirkarthi added a commit that referenced this pull request Jan 9, 2020
@miss-islington @blueyed @tirkarthi
Fix typo in test's docstring (GH-17856) (GH-17923)
Loading status checks…
e47a7e3 
* Fix typo in test's docstring. contination -> continuation.
(cherry picked from commit 2f65aa4)

Co-authored-by: Daniel Hahler <git@thequod.de>

Co-authored-by: Daniel Hahler <github@thequod.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tirkarthi tirkarthi

Assignees
No one assigned
Labels
CLA signed skip issue skip news type-tests
Projects
None yet
Milestone
No milestone
5 participants
@blueyed @tirkarthi @miss-islington @bedevere-bot @the-knights-who-say-ni
You can’t perform that action at this time.