Skip to content

/ cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-39215: Fix SystemError when nested function has annotation on positional-only argument #17826

Merged
merged 1 commit into from Jan 5, 2020
Merged

bpo-39215: Fix SystemError when nested function has annotation on positional-only argument #17826

merged 1 commit into from Jan 5, 2020

Conversation

@asottile
Copy link
Contributor

asottile commented Jan 5, 2020 •
edited by bedevere-bot

https://bugs.python.org/issue39215
@asottile
Fix SystemError when nested function has annotation on positional-onl…
Loading status checks…
2824e47 
…y argument
@ammaraskar ammaraskar requested a review from pablogsal Jan 5, 2020
@pablogsal
pablogsal approved these changes Jan 5, 2020
View changes
@pablogsal

This comment has been minimized.

Sign in to view
Copy link
Member

pablogsal commented Jan 5, 2020

Thanks for the quick fix, @asottile!
@pablogsal pablogsal merged commit ec007cb into python:master Jan 5, 2020
9 checks passed
9 checks passed
Docs
Details
Windows (x86)
Details
Windows (x64)
Details
macOS
Details
Ubuntu
Details
Azure Pipelines PR #20200105.1 succeeded
Details
bedevere/issue-number Issue number 39215 found
Details
bedevere/news News entry found in Misc/NEWS.d
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Jan 5, 2020

Thanks @asottile for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Jan 5, 2020

GH-17827 is a backport of this pull request to the 3.8 branch.
@asottile asottile deleted the asottile:fix_system_error_posonlyargs_annotations_39215 branch Jan 5, 2020
miss-islington added a commit that referenced this pull request Jan 5, 2020
@miss-islington @asottile
Fix SystemError when nested function has annotation on positional-onl…
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
8595255 
…y argument (GH-17826)

(cherry picked from commit ec007cb)

Co-authored-by: Anthony Sottile <asottile@umich.edu>
@sthagen sthagen mentioned this pull request Jan 5, 2020
Merged
gousaiyang added a commit to gousaiyang/cpython that referenced this pull request Jan 8, 2020
@asottile @gousaiyang
Fix SystemError when nested function has annotation on positional-onl…
5b00c35 
…y argument (pythonGH-17826)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablogsal pablogsal

Assignees
No one assigned
Labels
CLA signed
Projects
None yet
Milestone
No milestone
5 participants
@asottile @pablogsal @miss-islington @bedevere-bot @the-knights-who-say-ni
You can’t perform that action at this time.